-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RN upgrade: yarn.lock from main #6690
RN upgrade: yarn.lock from main #6690
Conversation
Packages used solely for development tools and testing have been moved from `dependencies` to `devDependencies`.
* feat: trigger qrsigning modal using approval controller * fix: use approval request to control QR modal * remove QRState usage * use approval request to control QR modal for tx * fix lint * add early return on qr signing modal --------- Co-authored-by: Vinicius Stevam <[email protected]> Co-authored-by: Vinicius Stevam <[email protected]>
Co-authored-by: SamuelSalas <[email protected]>
* fix(action): add required permissions to remove labels * fix(action name): adopt kebab case
The Yarn audit failure has been addressed by ignoring the flagged security advisory. It is a ReDoS advisory, which doesn't present a risk for us (it's not used for a server, so there is no way for an attacker to impact our availability). The audit file has been slightly reorganized to remove an obsolete comment, and to place the explanations above each entry rather than below.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
5b20128
to
0b8059c
Compare
SonarCloud Quality Gate failed. 3 Bugs 9.6% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
0b8059c
to
d68ea4b
Compare
Testing complete. Code changes will be addressed directly on #6220 |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
The goal is to maintain all functionalities with the minimal dependency changes.
yarn.lock change stats
on
upgrade/react-native/0.71.6-hermes
on this branch
rn-upgrade-new-yarnlock
Other changes
main
merge brings newer file changeshexToBN
catchall function since we are on the same version ofethereumjs-util
as in mainScreenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist