Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Approve button is always disabled for ERC721 tokens #6654

Closed
seaona opened this issue Jun 21, 2023 · 1 comment
Closed

[Bug] Approve button is always disabled for ERC721 tokens #6654

seaona opened this issue Jun 21, 2023 · 1 comment
Assignees
@blackdevelopa
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.2.0 release-7.2.0 Issue or pull request that will be included in release 7.2.0 release-blocker This bug is blocking the next release team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Jun 21, 2023

Describe the bug
The Approve button for ERC721 tokens is always disabled

Screenshots

approve-erc721-button-disabled.mp4

To Reproduce

  1. Go to test-dapp
  2. Deploy an NFT contract
  3. Mint a token
  4. Click Approve
  5. See how Approve button is always disabled

Expected behavior
Approve button should be enabled once gas estimation is ready

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: Android
  • App Version: 7.2.0 / main

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@seaona seaona added type-bug Something isn't working team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jun 21, 2023
@blackdevelopa blackdevelopa mentioned this issue Jun 21, 2023
Closed
3 tasks
@blackdevelopa blackdevelopa self-assigned this Jun 21, 2023
@bschorchit bschorchit added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-blocker This bug is blocking the next release release-7.2.0 Issue or pull request that will be included in release 7.2.0 labels Jun 21, 2023
@blackdevelopa blackdevelopa mentioned this issue Jun 21, 2023
Merged
3 tasks
@seaona seaona mentioned this issue Jun 23, 2023
Closed
@seaona seaona closed this as completed Jun 26, 2023
@marctatham
Copy link

I'm still seeing this issue on Android 🙄
Device: pixel 6
OS: Android 15

Recording:
https://github.com/user-attachments/assets/7d2cb0f7-b346-4111-a59c-8572d6047b04

@marctatham marctatham mentioned this issue Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackdevelopa blackdevelopa

Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.2.0 release-7.2.0 Issue or pull request that will be included in release 7.2.0 release-blocker This bug is blocking the next release team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@marctatham @blackdevelopa @bschorchit @metamaskbot @seaona