Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate test name lint warning #6304

Merged
merged 4 commits into from
May 1, 2023
Merged

Fix duplicate test name lint warning #6304

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e648cd
Fix duplicate test name lint warning
Gudahtt Apr 28, 2023
a900735
Merge branch 'main' into fix-duplicate-test-name
legobeat May 1, 2023
731b165
Merge branch 'main' into fix-duplicate-test-name
legobeat May 1, 2023
a64877a
Add further detail to test descriptions
Gudahtt May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/util/number/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,10 +781,10 @@ describe('Number utils :: isZeroValue', () => {
it('returns true for 0', () => {
expect(isZeroValue(0)).toBe(true);
});
it('returns true for 0x0', () => {
it('returns true for hexadecimal string 0x0', () => {
expect(isZeroValue('0x0')).toBe(true);
});
it('returns true for 0x0', () => {
it('returns true for hexadecimal integer literal 0x0', () => {
expect(isZeroValue(0x0)).toBe(true);
});
it('returns true for BN zero value', () => {
Expand Down