Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate test name lint warning #6304

Merged
merged 4 commits into from
May 1, 2023
Merged

Fix duplicate test name lint warning #6304

merged 4 commits into from
May 1, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 28, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

The lint warning about a test title being repeated has been fixed. The two tests were very similar; the titles have been updated to explain how they are different.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

The lint warning about a test title being repeated has been fixed. The
two tests were very similar; the titles have been updated to explain
how they are different.
@Gudahtt Gudahtt requested a review from a team as a code owner April 28, 2023 22:10
@Gudahtt Gudahtt added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Apr 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed this too earlier but spotted new conflicts to resolve when back in the office
tiny bit more explicitness would be perfect wording imo (ref)

app/util/number/index.test.ts Outdated Show resolved Hide resolved
app/util/number/index.test.ts Outdated Show resolved Hide resolved
@Gudahtt Gudahtt merged commit effdbdb into main May 1, 2023
@Gudahtt Gudahtt deleted the fix-duplicate-test-name branch May 1, 2023 13:57
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants