TX Notifications #447
Merged
TX Notifications #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
reviewed
Feb 28, 2019
estebanmino
reviewed
Feb 28, 2019
| _getDescription = () => strings(`notifications.${type}_message`); | ||
|
|
||
| // eslint-disable-next-line | ||
| _getContent = () => ( |
There was a problem hiding this comment.
why are you using methods with '_' now?
There was a problem hiding this comment.
There are private methods and public on that module. Need an easy way to differentiate it.
estebanmino
reviewed
Feb 28, 2019
estebanmino
reviewed
Feb 28, 2019
| // If a TX has been confirmed more than 10 min ago, it's considered old | ||
| const oldestTimeAllowed = Date.now() - 1000 * 60 * 10; | ||
|
|
||
| if (transactions.length) { |
There was a problem hiding this comment.
this if is checking selectedAddress and network to send notifications so if you are in ropsten and you get a tx in mainnet it won't show any notification, same for different accounts. I built the app to confirm this.
There was a problem hiding this comment.
Yeah, you'll receive notifications only for the current network. Did this on purpose. Will explain why offline
estebanmino
approved these changes
Feb 28, 2019
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* initial POC * initial POC * fix nav structure * fix modals * UI completed and manager ready * shit works * error notifications * fix styling * fix spinner on android * clean up * incoming notifications working * prevent continuous re-render * fix timeout * fix polling interval * refactor to support local notifications * everything working except for android * android notifications working * more android changes * handle background and foreground modes * fix unit tests * fix wrong date fn * fix vuln * fixes * fix unit tests * clean up * more clean up * code review comments * typo * missing condition * android fixes
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
## **Description** * '@ethersproject/abi' - Can be cleaned from package.json since it's only used by dependencies  * @react-native-picker/picker - There is no usage for a picker anymore in the mobile app ([Introduced here](#3776))  * @rnhooks/keyboard - There is no usage for @rnhooks/keyboard ([introduced here](#1994))  * asyncstorage-down - there is no usage of asyncstorage-down ([introduced here] This one was added back, but most likely isn't needed and we need to think about replacing `react-native-level-fs` and use only one file system library * dnode - there is no usage of dnode ([introduced here](#2798)) ## **Related issues** Fixes: * obs-store - There is no usage of obs-store anymoer (introruced [here](#1236))   * react-native-flash-message - there is no usage anymore ([introduced here](#447))   * react-native-redash - there is no usage anymore (react-native-redash)   ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BONUS:
metro-react-native-babel-presetto 0.52.0Checklist
Issue
Resolves #176
Resolves #442
For incoming transactions to work properly on testnets we need to merge: MetaMask/core#62
DEMO: http://recordit.co/8dys9QTkca