Feature: Initial Swaps amount view #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
approved these changes
Dec 4, 2020
ibrahimtaveras00
added
the
needs-qa
ibrahimtaveras00
suggested changes
Dec 7, 2020
There was a problem hiding this comment.
Only padding issue I saw was on Android Nexus S (4 inch screen)
Nonetheless, you can scroll on this view so it's not too big of a problem
Another issue I saw was that the title Convert to or Convert from is cut off on smaller Android devices when keyboard is expanded when searching token list
In this example, this is a pixel (5 inch screen) on left compared to iPhone SE 2nd generation
ibrahimtaveras00
added
QA'd - Issues Found
|
I pushed an updated code with conditional height for the list depending wether the keyboard is open and the device size in order to keep the UI contained in the viewport at all times.
|
3 tasks
ibrahimtaveras00
approved these changes
Dec 10, 2020
ibrahimtaveras00
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
Co-authored-by: Esteban Mino <[email protected]>
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
## **Description** * '@ethersproject/abi' - Can be cleaned from package.json since it's only used by dependencies  * @react-native-picker/picker - There is no usage for a picker anymore in the mobile app ([Introduced here](#3776))  * @rnhooks/keyboard - There is no usage for @rnhooks/keyboard ([introduced here](#1994))  * asyncstorage-down - there is no usage of asyncstorage-down ([introduced here] This one was added back, but most likely isn't needed and we need to think about replacing `react-native-level-fs` and use only one file system library * dnode - there is no usage of dnode ([introduced here](#2798)) ## **Related issues** Fixes: * obs-store - There is no usage of obs-store anymoer (introruced [here](#1236))   * react-native-flash-message - there is no usage anymore ([introduced here](#447))   * react-native-redash - there is no usage anymore (react-native-redash)   ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the initial swaps amount view. For now slippage is fixed at 1%.
Draft Checklist
Checklist
Issue
Resolves #???