Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce non error objects into errors before sending to sentry #1874

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Coerce non error objects into errors before sending to sentry #1874

merged 3 commits into from
Oct 13, 2020

Commits on Oct 13, 2020

  1. Coerce non error objects into errors 

    It seems like we're passing non errors to sentry

re: https://sentry.io/organizations/metamask/issues/1641747298/?project=2299799&query=is%3Aunresolved&statsPeriod=14d

I realise we should fix this underlying issue, but adding this will allow us to make mistakes without upsetting the Sentry gods
At least, that's my hope 🙏
    @rickycodes
    rickycodes committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    445213a View commit details
    Browse the repository at this point in the history

  2. create specific errors for string and object types

    @rickycodes
    rickycodes committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    3ef6780 View commit details
    Browse the repository at this point in the history

  3. Shift logic into "metricsOptIn === AGREED" section

    @rickycodes
    rickycodes committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    c902a1b View commit details
    Browse the repository at this point in the history