Coerce non error objects into errors before sending to sentry #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
changed the title
rickycodes
added
the
needs-dev-review
andrepimenta
requested changes
Oct 13, 2020
There was a problem hiding this comment.
This makes a lot of sense to me, really important!
But should we also check if the exception is a string and put that string instead of 'error to capture is not an error instance'?
And also check if the exception is an object and do JSON.stringify and put that instead of 'error to capture is not an error instance'?
I think it would help us further differentiate errors.
rickycodes
force-pushed
the
bugfix/fix-sentry-logging-issue
branch
from
7e49ded
to
d55ae15
Compare
It seems like we're passing non errors to sentry re: https://sentry.io/organizations/metamask/issues/1641747298/?project=2299799&query=is%3Aunresolved&statsPeriod=14d I realise we should fix this underlying issue, but adding this will allow us to make mistakes without upsetting the Sentry gods At least, that's my hope 🙏
rickycodes
force-pushed
the
bugfix/fix-sentry-logging-issue
branch
from
d55ae15
to
3ef6780
Compare
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Coerce non error objects into errors It seems like we're passing non errors to sentry re: https://sentry.io/organizations/metamask/issues/1641747298/?project=2299799&query=is%3Aunresolved&statsPeriod=14d I realise we should fix this underlying issue, but adding this will allow us to make mistakes without upsetting the Sentry gods At least, that's my hope 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we're passing non errors to sentry
re: https://sentry.io/organizations/metamask/issues/1641747298/?project=2299799&query=is%3Aunresolved&statsPeriod=14d
I realise we should fix this underlying issue, but adding this will allow us to make mistakes without upsetting the Sentry gods
At least, that's my hope 🙏
Checklist
Issue
Resolves #???