Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow webview debugging in dev mode + XIP #1806

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Allow webview debugging in dev mode + XIP #1806

merged 4 commits into from
Oct 14, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Aug 31, 2020 •
edited
Loading

Description

Enables webview debugging on Android during dev mode, and temporarily allows xip connections so we can use http://LOCAL_IP for development

Resolves #923

@EtDu EtDu requested a review from a team as a code owner August 31, 2020 05:49
@EtDu EtDu added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 31, 2020
@EtDu EtDu mentioned this pull request Sep 1, 2020
Merged
@estebanmino
Copy link
Contributor

what about allowing http by default? I'm in favor of it, we do it on ios and we don't on android just because you have to do other configuration https://stackoverflow.com/a/51902630 cc @andrepimenta since you're working on the browser refactor

@EtDu
Copy link
Contributor Author

EtDu commented Sep 2, 2020 •
edited
Loading

I think we should use a similar solution for iOS, instead of arbitrarily allowing http. This sounds best from a security standpoint, especially since we can without any compromise.
@omnat thoughts on this?

@omnat
Copy link
Contributor

omnat commented Sep 15, 2020

Trust judgement of @andrepimenta on this.

@EtDu EtDu changed the title Use xip to allow local ip connections Allow webview debugging on dev mode Sep 21, 2020
@EtDu EtDu changed the title Allow webview debugging on dev mode Allow webview debugging in dev mode Sep 21, 2020
@EtDu
Copy link
Contributor Author

EtDu commented Sep 21, 2020 •
edited
Loading

Changed PR based on recent decisions:

  • allow http always with warning (separate PR)
  • allow webview debugging in dev mode
  • allow XIP for local connections (temporary)

@EtDu EtDu force-pushed the http-custom-network branch from 96407e0 to d12a77e Compare September 21, 2020 04:04
@EtDu EtDu changed the title Allow webview debugging in dev mode Allow webview debugging in dev mode + XIP Sep 21, 2020
@EtDu EtDu force-pushed the http-custom-network branch from fd0dc57 to 7b7b0ee Compare October 8, 2020 04:17
@EtDu EtDu added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 8, 2020
@EtDu
Copy link
Contributor Author

EtDu commented Oct 8, 2020

@ibrahimtaveras00 For QA:

  1. See if you can debug android webview https://github.com/MetaMask/metamask-docs/pull/169/files#diff-ea52e377c8d802334edebc350d1ea8a1R101
  2. See if you can connect to a server running on a computer using the same wifi as the phone https://github.com/MetaMask/metamask-docs/pull/169/files#diff-ea52e377c8d802334edebc350d1ea8a1R83

ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 13, 2020
@EtDu EtDu merged commit 1ce4036 into develop Oct 14, 2020
@EtDu EtDu deleted the http-custom-network branch October 14, 2020 03:41
@JavonneM JavonneM mentioned this pull request May 24, 2021
Merged
3 tasks
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu
Allow webview debugging in dev mode + XIP (#1806)
b939e03 
* Enable webview debugging on android in dev mode

* allow XIP for local connections

* change to Buildconfig.DEBUG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to use http://your_local_ip for development
4 participants
@EtDu @estebanmino @omnat @ibrahimtaveras00