Allow webview debugging in dev mode + XIP (#1806)

* Enable webview debugging on android in dev mode * allow XIP for local connections * change to Buildconfig.DEBUG
MetaMask · Oct 14, 2020 · 1ce4036 · 1ce4036
1 parent 7adf92b
commit 1ce4036
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
@@ -11,6 +11,7 @@
 
 	<application
 		android:name=".MainApplication"
+    android:debuggable="${isDebug}"
 		android:label="@string/app_name"
 		android:icon="@mipmap/ic_launcher"
 		android:roundIcon="@mipmap/ic_launcher_round"

diff --git a/android/app/src/main/java/io/metamask/MainApplication.java b/android/app/src/main/java/io/metamask/MainApplication.java
@@ -16,6 +16,7 @@
 import java.lang.reflect.InvocationTargetException;
 import java.util.List;
 import io.metamask.nativeModules.PreventScreenshotPackage;
+import android.webkit.WebView;
 
 import androidx.multidex.MultiDexApplication;
 
@@ -54,6 +55,8 @@ public ReactNativeHost getReactNativeHost() {
 	@Override
 	public void onCreate() {
 		super.onCreate();
+    if (BuildConfig.DEBUG)
+    { WebView.setWebContentsDebuggingEnabled(true); }
 		SoLoader.init(this, /* native exopackage */ false);
 
 		initializeFlipper(this, getReactNativeHost().getReactInstanceManager());

diff --git a/android/app/src/main/res/xml/react_native_config.xml b/android/app/src/main/res/xml/react_native_config.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <network-security-config>
 	<domain-config cleartextTrafficPermitted="true">
+    <domain includeSubdomains="true">xip.io</domain>
 		<domain includeSubdomains="false">localhost</domain>
 		<domain includeSubdomains="false">10.0.2.2</domain>
 		<domain includeSubdomains="false">10.0.3.2</domain>