Detect if site has been added to Favorites #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
commented
May 2, 2020
estebanmino
added
the
needs-qa
|
@ibrahimtaveras00 this should be good for QA |
ibrahimtaveras00
approved these changes
May 6, 2020
ibrahimtaveras00
added
QA Passed
Previously we were `Alert`ing after attempting to `addBookmark`. Instead, we remove the option from the menu entirely. closes: #1511
estebanmino
added a commit
that referenced
this pull request
May 15, 2020
* Loosen nvmrc (#1524) Co-authored-by: Esteban Miño <[email protected]> * bugfix/check for sai method (#1545) * update docs link in readme (#1521) Co-authored-by: Esteban Miño <[email protected]> * Add settings to nav bar (#1544) * Add settings to nav bar * Remove settings Icon * Add icons for all drawer links * Improvement/tx status notification (#1475) * simple not update * text update * wip * delete old details * delete old confirm * almost done withtx details * modal working * modal title * rm transfer element * clean * fix transfer * transfer and payment channel * decodeTransferFromTx * decodeDeploymentTx * decodeConfirmTx * onpress * status * close on view web * more cleanup * payment * showing not * closer? * comment * tx details and not * animated * tx not * enable access view on not * animated * rename * using txnnot manager * working * receive * rm unused * rm logs * handle browser not * parse date * handle asset details * tx summary rename props * Refactor names in details * handle primary currency * missing props * almost there * working but browser * finally * one more thing * done * snaps * missing locales * update ethereum address * snaps * handle instapay txs * snaps * feeless tx * data check * No fee * instance._hideTransactionNotification * fix instapay notifications * elevation * fix remaining issues * apeed up cancel * transaction modal * speed cancel * speedup cancel ui * working * added engine methods * done * snaps * fix qaing * fix ios build * one snap * remove test * status text fix * cancelled * margin * snaps * fix insufficient funds * doc * Transaction Header Component (#1487) * Remove redundant imports, remove redundant styles, comment typo correction, remove renderPageInformation(), split props line by line in render(), swap rendering renderPageInformation() with TransactionHeader component, pass props * added lock and warning icons * removed domain prop * new TransactionHeader component, imports, styling, prop types, lock/warning icon change based on URL protocol, network status indicator (color) changes if network is online/not online * re-generated snapshot for SignatureRequest, created new test for TransactionHeader * network changes based on selected network * update snapshot * update snapshot * remove function, use css for network capitalization * move network status logic to renderNetworkStatusIndicator() * render icon logic moved to renderSecureIcon() * add comments * update snapshot * remove redundant getTrackingParams, use props directly * remove png icons from image dir, use react native svg icons (FontAwesome), update snapshot * TransactionHeader: use 'Ethereum' instead of 'Mainnet' * Add shortnames to networks util, TransactionHeader: use networks util to display network name, update snapshot * Remove redundant imports, remove redundant styles, comment typo correction, remove renderPageInformation(), split props line by line in render(), swap rendering renderPageInformation() with TransactionHeader component, pass props * added lock and warning icons * removed domain prop * new TransactionHeader component, imports, styling, prop types, lock/warning icon change based on URL protocol, network status indicator (color) changes if network is online/not online * re-generated snapshot for SignatureRequest, created new test for TransactionHeader * network changes based on selected network * update snapshot * update snapshot * remove function, use css for network capitalization * move network status logic to renderNetworkStatusIndicator() * render icon logic moved to renderSecureIcon() * add comments * update snapshot * remove redundant getTrackingParams, use props directly * remove png icons from image dir, use react native svg icons (FontAwesome), update snapshot * TransactionHeader: use 'Ethereum' instead of 'Mainnet' * Add shortnames to networks util, TransactionHeader: use networks util to display network name, update snapshot * fixed import error Co-authored-by: Esteban Miño <[email protected]> * Feature/block screenshots (#1495) * native * test on wallet * block in some screens * ios check * rm asyncs * helper * missing places * Detect if site has been added to Favorites (#1538) * Detect if site has been added to Favorites Previously we were `Alert`ing after attempting to `addBookmark`. Instead, we remove the option from the menu entirely. closes: #1511 * Rename isFavorite -> isBookmark * Use "web-search" keyboardType on iOS (#1539) * Use web-search keyboard Use web-search for the omnibar keyboard * Add new mobile provider (#1517) Co-authored-by: Esteban Miño <[email protected]> * Sig request design fixed (#1493) * new folder for AccountInfoCard component, remove signature_request.title from message, personal & typed sign components, remove redundant style * SignatureRequest: remove account information from top, proptypes, props, styles, imports * SignatureRequest: change signing message to 'Sign this message?', make bold and larger * remove keyboard aware scroll view * Add AccountInfoCard component to SignatureRequest * AccountInfoCard: implement proper styling * AccountInfoCard: use renderShortAddress, fix styles, use conversionRate to display $ amount * ActionView: add isSigning prop, disables scroll when true, SignatureRequest: pass isSigning=true to ActionView * AccountInfoCard: remove top level view * SignatureRequest: apply styles & layout, add website + arrow icons * Signing components: update styling, rename informationRow --> informationCol * remove message style * TypedSign: put back message style, add messageWrapper style, ensure data fits in box and hides overflow * AccountInfoCard: add snapshot test * update snapshots * styling of 'sign this message' * update snapshot * update snapshot * SignatureRequest: Always render arrow if children coming from TypedSign * SignatureRequest: change to regular component with state to show expanded message content, wrap touchableWithoutFeedback around the message children and move rendering to renderActionViewChildren, tapping the message currently does nothing * fix dapp icon style, fix render inf loop * remove textwrap for typed sign. Now renders properly for V1, V3 & V4 * AccountInfoCard: fix paddings, identicon style, use widths instead of flex, float address to left, fix font weights * TypedSign: use width instead of flex * SignatureRequest: remove website icon wrapper, fix arrow positioning, remove assetLogo style * temp disable warning to match style, ensure message fits within box * PersonalSign: create message wrapper, ensure message fits within box * Message & Personal Sign: use ellipses mode for text wrapper, drop messageWrapper styles * SignatureRequest: remove shouldRenderArrow, add shouldRenderArrow prop * MessageSign: change to stateful component, add renderArrow state, decides if should render arrow upon text component layout, then adjusts the text accordingly * PersonalSign: change to stateful component, add renderArrow state, decides if should render arrow upon text component layout, then adjusts the text accordingly * TypedSign: shouldRenderArrow always passes down as true. Will never be a situation where an entire typed message fits in the box * SignatureRequest: change back to pure component, change handleMessageTap into prop * change handleMessageTap to toggleExpandedMessage * TypedSign: implement message expansion and retraction * modify message, add message_from * new ExpandedMessage component, rendered by typed, personal & regular message components * TypedSign: use ExpandedMessage component * ExpandedMessage: test * SignatureRequest: add renderArrow prop, make box not expandable if false * MessageSign: implement message expanding and retracting * PersonalSign: implement message expand & retract * ExpandedMessage: add mock fns, update all snapshots * ActionView: get rid of top border * new button styles * signing components: ensure a top left and right rounded border * change Cancel & Sign to lowercase * snapshot update * adjust style for android * use unique button style for signing components, fix percentage in stylesheet * change isSigning prop to noScroll * snapshot update * update more snapshots * Signing components: revert to pure component * AccountInfoCard: use weiToFiat & hexToBn helpers to display fiat value, add currentCurrency prop * Signing components: shift renderRootView() contents into render() * update snapshot * AccountInfoCard, SignatureRequest: fix paddings per design * AccountInfoCard: remove bottom margin * TransactionHeader: remove margins, use padding * MessageSign: larger min height, showWarning prop * WarningMessage: use flexstart alignment for bell icon * locales: change eth_sign_warning * WarningMessage: add object as secondary prop type for warning message * SignatureRequest: use WarningMessage component, fix paddings, use renderWarning as prop for WarningMessage * snapshot update yo * SignatureRequest: move AccountInfoCard ontop of message children * snapshot update * AccountInfoCard: remove width * ActionView: remove no scroll - small devices * Signing Components: remove root style, move to SignatureRequest * SignatureRequest: remove style redundancies, add in root style * SignatureRequest: fix height of modal based on screen height * ExpandedMessage: fix styling, move scrollview to signing components renderMessage * ExpandedMessage: Put the scroll back * PersonalSign: remove expandedMessage text wrapper * SignatureRequest: fix up styling, add more overhead (reduced from signing components) * Signing components: reduce view hierarchy, move to SignatureRequest * Locales: add Read more to signature_request * AccountInfoCard: add operation prop, if operation is signing, only display the account name and address * TypedSign: add shouldTruncateMessage & truncateMessage in state * PersonalSign: remove console log * Signing components: change renderArrow to truncateMessage * Nav/Main: add showExpandedMessage to state, add toggleExpandedMessage, configure expanded signing modal to go back on android back button press, pass down props to signing components * Signing Components: move showExpandedMessage out of state, move out toggleExpandedMessage * TypedSign: create different messageWrapper height for iOS & Android, fix text clipping mid-line * ExpandedMessage: fix scrollview * snapshot update * AccountInfoCard: use getTicker * Signing components: change margin bottom from 5 to 4 * Device: new getMediumDevice, SignatureRequest: use getMediumDevice * ActionView, styledButtonStyles: add cancel button style for signing components * snapshot update * SignatureRequest: fix the domain logo not being a circle * update snapshot * Use [email protected] (#1552) * Fix settings everywhere (#1556) * Fix day and month numbers in toDateFormat (#1557) * Make send flows consistent (#1465) * Move components and styles from Confirm into TransactionReview * Add ActionView back in * Add missing styles * Revert TransactionReview changes * Update send screen: from accounts editable and redesign gas edit link * Use sendflow confirm for payment requests and when editing * Update sendflow/confirm tests * Use new send flow designs for instapayment / payment channel transactions * Use existing send flow screens for deep link transactions * Fix editing of payment request transactions * Fix unit tests on consistent-send-flow branch * Fix navigation for deep link tx edits on the amount screen. * Refactor: combine transaction and newTransaction reducers * Fix bugs on consistent-send-flow * Fix confirm and edit of transactions created from dapps * Update transaction edit text color * Only allow changing from field on confirm screen of payment requests * Fix amount validation for payment channel transactions * Fix qr payment requests, payment channel payment requests, and token payment requests; plus other small fixes * Fix token approvals * Fix sending of decimals on payment channles * Show correct error messages when accounts are changed and/or token balances are insufficient * Update navbar options in edit mode * Ensure tokens cannot be sent in cases where user has not added the token * Correctly validate payment channel transaction on mount/update * Use sai.svg instead of dai.svg Co-authored-by: Dan Miller <[email protected]> Co-authored-by: Esteban Miño <[email protected]> * Use setTimeout hack (again) to get paste context in token search (#1548) * Use setTimeout hack (again) to get paste context in token search * Update test Co-authored-by: Esteban Miño <[email protected]> * V0.2.16 (#1561) * bump * changelog * rm entry * Fix amount validation for large token payment requests (#1572) * Fix validating of amount when sending a collectible (#1565) * Fix validating of amount when sending a collectible * Validate collectible ownership on amount screen. * Ensure correct updating of collectible transaction after edit on the amount screen * Ensure collectibles that use 'transfer' method show a fee in tx history list (#1574) Co-authored-by: Esteban Miño <[email protected]> * Disable confirm screen edit button when no tokens of a payment request (#1570) * Disable confirm screen edit button when account has no tokens of a payment request * Ensure account switching from undefined token balance accounts enables edit on pay reqs * Improve logic in componentDidUpdate of send/index.js * v0.2.16 changelog (#1575) * Instapay deposit navbar cancel (#1582) * fix * works * rm log * add this to changelog and update date * amount title Co-authored-by: Erik Marks <[email protected]> Co-authored-by: Jenny Pollack <[email protected]> Co-authored-by: ricky <[email protected]> Co-authored-by: Etienne Dusseault <[email protected]> Co-authored-by: Whymarrh Whitby <[email protected]> Co-authored-by: Ibrahim Taveras <[email protected]> Co-authored-by: Dan J Miller <[email protected]>
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Detect if site has been added to Favorites Previously we were `Alert`ing after attempting to `addBookmark`. Instead, we remove the option from the menu entirely. closes: #1511 * Rename isFavorite -> isBookmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were
Alerting after attempting toaddBookmark.Instead, we remove the option from the menu entirely if and when the bookmark already exists.
closes: #1511
Checklist
Issue
Resolves #1511