Detect if site has been added to Favorites (#1538)

* Detect if site has been added to Favorites

Previously we were `Alert`ing after attempting to `addBookmark`.

Instead, we remove the option from the menu entirely.

closes: #1511

* Rename isFavorite -> isBookmark

app/components/Views/BrowserTab/index.js

@@ -1167,11 +1167,6 @@ export class BrowserTab extends PureComponent {
 
 	addBookmark = () => {
 		this.toggleOptionsIfNeeded();
-		// Check it doesn't exist already
-		if (this.props.bookmarks.filter(i => i.url === this.state.inputValue).length) {
-			Alert.alert(strings('browser.error'), strings('browser.bookmark_already_exists'));
-			return false;
-		}
 		this.checkForPageMeta(() =>
 			this.props.navigation.push('AddBookmarkView', {
 				title: this.state.currentPageTitle || '',
@@ -1498,14 +1493,16 @@ export class BrowserTab extends PureComponent {
 						{strings('browser.reload')}
 					</Text>
 				</Button>
-				<Button onPress={this.addBookmark} style={styles.option}>
-					<View style={styles.optionIconWrapper}>
-						<Icon name="star" size={16} style={styles.optionIcon} />
-					</View>
-					<Text style={styles.optionText} numberOfLines={1}>
-						{strings('browser.add_to_favorites')}
-					</Text>
-				</Button>
+				{!this.isBookmark() && (
+					<Button onPress={this.addBookmark} style={styles.option}>
+						<View style={styles.optionIconWrapper}>
+							<Icon name="star" size={16} style={styles.optionIcon} />
+						</View>
+						<Text style={styles.optionText} numberOfLines={1}>
+							{strings('browser.add_to_favorites')}
+						</Text>
+					</Button>
+				)}
 				<Button onPress={this.share} style={styles.option}>
 					<View style={styles.optionIconWrapper}>
 						<Icon name="share" size={15} style={styles.optionIcon} />
@@ -1865,6 +1862,12 @@ export class BrowserTab extends PureComponent {
 		return activeTab === id;
 	};
 
+	isBookmark = () => {
+		const { bookmarks, navigation } = this.props;
+		const currentUrl = navigation.getParam('url', null);
+		return bookmarks.some(({ url }) => url === currentUrl);
+	};
+
 	isHomepage = (url = null) => {
 		const currentPage = url || this.state.inputValue;
 		const { host: currentHost, pathname: currentPathname } = getUrlObj(currentPage);

locales/en.json

@@ -575,7 +575,6 @@
 		"bookmark": "Bookmark",
 		"add_to_favorites": "Add to Favorites",
 		"error": "Ooops!",
-		"bookmark_already_exists": "You already bookmarked this url",
 		"cancel": "Cancel",
 		"go_back": "Go back",
 		"go_forward": "Go forward",

locales/es.json

@@ -544,7 +544,6 @@
 		"bookmark": "Marcar",
 		"add_to_favorites": "Agregar a favorites",
 		"error": "Ooops!",
-		"bookmark_already_exists": "Ya agregaste esta url a tus favoritos",
 		"cancel": "Cancelar",
 		"go_back": "Atrás",
 		"go_forward": "Avanzar",