Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vertical padding to close button #1398

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Add vertical padding to close button #1398

merged 2 commits into from
Mar 5, 2020

Conversation

rickycodes
Copy link
Contributor

Description

Noticed this while working through #1390... just adding some verticalPadding to the Edit/Cancel (closeButton) so it's a bit easier to hit (similar to #1380 and #1333)

Before

Screenshot from 2020-03-03 15 13 42
Screenshot from 2020-03-03 15 14 13

After

Screenshot from 2020-03-03 15 11 19
Screenshot from 2020-03-03 15 11 48

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 3, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on various real devices on both OS's and all looks good, QA Passed 👍

estebanmino
estebanmino approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estebanmino estebanmino merged commit 1722b62 into develop Mar 5, 2020
@whymarrh whymarrh deleted the add-padding-close-button branch March 19, 2020 03:07
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Add vertical padding to close button (#1398)
8943fa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickycodes @estebanmino @ibrahimtaveras00