Add padding to top and bottom of hamburgerButton #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
increase-hamburger-menu-hittest
branch
from
c6dab4d
to
68aea16
Compare
estebanmino
approved these changes
Feb 19, 2020
estebanmino
added
the
needs-qa
rickycodes
force-pushed
the
increase-hamburger-menu-hittest
branch
from
68aea16
to
85e57bc
Compare
|
Android looks good 👍 However, on iOS, only while on the browser, the menu tap area only shows two lines compared to the traditional three lines
checked on: I couldn't see this issue at all happening on the following Android devices: |
rickycodes
force-pushed
the
increase-hamburger-menu-hittest
branch
from
040365e
to
4e29a46
Compare
ibrahimtaveras00
approved these changes
Feb 20, 2020
3 tasks
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Add padding to top and bottom of hamburgerButton * Decrease top and bottom padding for iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #1333 this increases top and bottom padding for the hamburger menu icon so there's less chance of missing it. I also removed the
moreIconwhich is unused and opted to create a newhamburgerButtonstyle key sincebackButtonis being used for other items.this will need to be tested.
Before
After
Checklist
Issue
Resolves #???