Feature: address book + new send flow #1239
Conversation
|
All above issues have been fixed 👍 Issue 10: placeholder text is cut off on android devices (checked Pixel 3 and Nexus S)
Issue 11: The tappable area for changing to currency is hard on the real iPhone SE, I can't seem to tap it.
Issue 12: Nexus S (4 inch screen) collectible title
Issue 13: Currently on playstore/appstore, if you scan a public address QA code, it pre-fills in the to field, however, on this branch I get sent to the send view without the address pre-filled; seen here = http://recordit.co/jqwo40zf9n |
|
Issue 14: Adding an account and removing an account in Settings > Contacts not updating correctly; seen here = https://recordit.co/73q6byZQVR steps:
Issue 15: Transaction error
Flow seen here = https://recordit.co/OOpgd447A5 Steps: |
|
Issues 10 - 13 have been resolved 👍 Issue 14 = Originally reported bug is fixed, however, it seems as though when I have 0 accounts and I attempt to add my first account, my contacts list isn't updated until I leave Contacts and go back into Contacts seen here = https://recordit.co/g36Ea1MHs9 (0:01 - 0:49sec) Issue 15 = Still happening After doing 1 last run through, I noticed this: Issue 16: = I was able to add a contact with a space as a character, as well as an emoji, so when it appeared on the list, there was no icon for the one with the space, and a different icon for the one with the emoji, do we want to group them under the "others"? seen here = https://recordit.co/EBjVH4vwdh
|
* basic components * basic components * updates * wip * between my accounts * basic add contact * render list * inputs func components * handle from selection * from identicon * onchangetoaddress * add to address book modal * add from modal and parse asdress book * scan qr * select own accounts * reverse ens and better state * handle parse * clear to * handle account label * next and redux * handle to ens * parse address book * handle send flow navigation * amount view * render only tokens * pick selected asset * redux set selected address * use max * switch currency * confirm * clean * init confirm * confirm view * render fiat in confirm * handle eth txs * handle erc20 txs * parseTransactionData * wait for gas estimation * custom gas modal * handle gas selection * handle advanced tx fee * custom gas improvs * handle gas selected * handle current selected when cancel * use time estimates * handle amount errors * address search * typo * recents * parsedRecents * cleaner code * handle address errors * handle more error cases * fix usemax * handle global primary currency * handle use max with fiat as prim currency * switch currency working * set asset before and fix switched symbol * render gas wait time * improve gas selectors * add weeks and days * better parsewaittime * fix selected asset change * improve conversion * parseTransactionData " * validate gas on confirm * handle use max with gas for eth * add gas estimation in amount * estimatedTotalGas once on mount * send tx * gas bug on amount * render collectibles in list * handle collectibles list and data * handle collectible on confirm * ignore No stops in gradient * handle focus * handle tradable collectibles and sort them * handle tokens without exchange rate * check collectible removal * start tx from asset * go to new send flow from everywhere * hex data modal * reset tx on unmount * delete unused files * reset tx * start tx with asset * redux update * clean state * isETH * highlight address to * use currency symbols and texttransfor uppercase * handle currency code in amount input * send to up to date design * amount up to date design * confirm up to date design * send to up to date design android * next buttons margin bottom * input amount font * fix texts color * fix androi dpaste * alignments * handle mmm txs * handle ens name when resolved * formatting and locales * add contacts from settings * no need for edit component * handle add validation * locales * rename route * delete contact * spanish * handle scan and android' * more locales * address ready when edit * snappppppsSs * others * fix reverse ens * disable add address without an alias * fixes * address elemenr * snaps * custom gas validation * locale missing * check decimal * comments * snaps * fix key * fix assets * fix use mac * renderFiatAddition * fix empty data * snaps * fix gas calculation for erc721 * rm logs * validation * handle change from without asset * use flat list * rm unused code * rename * fix delete * fix empty bug * fix margin issue 10 * issue 11 * 12 * send qr to old sendflow 13 * snaps * fix others contacts * fix edit * use mac * lte * bn(0) * fix 13 * handle space and emojis * fix validation * contact form with refs * snapS
Description
Write a short description of the changes included in this pull request.
Checklist
Issue
Resolves #128