Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Address value component for use in re-designed confirmation pages #11815

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 16, 2024

Description

Address value component for use in re-designed confirmation pages

Related issues

Fixes: #11793

Manual testing steps

  1. Enable re-designs locally
  2. Go to test dapp
  3. Open personal sign page
  4. Navigate to network header info section

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 16, 2024
@jpuri jpuri requested review from a team as code owners October 16, 2024 11:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Oct 16, 2024

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 16, 2024
@jpuri jpuri added this pull request to the merge queue Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f3b44b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/09acd530-58c3-4738-92ad-2b207e860c59

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Merged via the queue into main with commit 8034339 Oct 16, 2024
38 of 40 checks passed
@jpuri jpuri deleted the address_value_component branch October 16, 2024 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create address value type field
3 participants