Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create address value type field #11793

Closed
jpuri opened this issue Oct 15, 2024 · 0 comments · Fixed by #11815
Closed

Create address value type field #11793

jpuri opened this issue Oct 15, 2024 · 0 comments · Fixed by #11815
Assignees
@jpuri
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-7.34.0 team-confirmations Push issues to confirmations team

Comments

@jpuri
Copy link
Contributor

jpuri commented Oct 15, 2024 •
edited
Loading

Similar to extension we need an address value component to display address values:

Image

Figma: https://www.figma.com/design/CeAIcptzeaI5ciTpYBaiqr/Confirmations-DS?node-id=4314-18587&node-type=canvas&t=cIHseE7PzxUqbrM0-0
@jpuri jpuri self-assigned this Oct 15, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Oct 15, 2024
@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 15, 2024
@jpuri jpuri mentioned this issue Oct 16, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2024
@jpuri
feat: Address value component for use in re-designed confirmation pag…
8034339 
…es (#11815)

## **Description**
Address value component for use in re-designed confirmation pages

## **Related issues**

Fixes: #11793

## **Manual testing steps**

1. Enable re-designs locally
2. Go to test dapp
3. Open personal sign page
4. Navigate to network header info section

## **Screenshots/Recordings**
TODO

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-7.34.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Address value component for use in re-designed confirmation pages MetaMask/metamask-mobile
2 participants
@jpuri @metamaskbot