Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): upgrade sdk to 1.28.5 #11788

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 14, 2024

Description

  • update on-ramp-sdk to version 1.28.5, which removes a unused dependency

Related issues

Fixes: dependency issue

Manual testing steps

  • go to buy crypto
  • request a quote
  • quote should be provided

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added team-ramp issues related to Ramp features ramp-qa-passed labels Oct 14, 2024
@wachunei
Copy link
Member Author

I confirm quotes are loading correctly.

@wachunei wachunei marked this pull request as ready for review October 14, 2024 19:13
@wachunei wachunei requested review from a team as code owners October 14, 2024 19:13
@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 14, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/[email protected] None 0 390 kB pmkowalski

🚮 Removed packages: npm/@consensys/[email protected]

View full report↗︎

@wachunei wachunei added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 07169fd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ec08c791-2f82-4d40-92db-ab82f13c1dc1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 14, 2024

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 14, 2024
@wachunei wachunei added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 4f8f66c Oct 14, 2024
58 of 61 checks passed
@wachunei wachunei deleted the chore/ramp-upgrade-sdk-1.28.5 branch October 14, 2024 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants