fix: non deterministic date in test

[NicolasMassart]

Description

Fixes date that was generating an ever changing duration in the snapshot.

• replace it with a relative date to the moment the test is running to make the duration always one day: the notification renders as if it was sent yesterday, always.
• fix duration to one day (yesterday) as we have to fix one and it's not a worse value than any other.
• rename test case to match guideline while I was on it...

Related issues

Fixes #11785

Manual testing steps

N/A

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4083df1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/727bd43c-8217-4017-9572-782d0fa76512

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[NicolasMassart]

Update with #11788 once merged

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud