fix: fix non regression tests

[salimtb]

Description

This PR addresses multiple areas to improve the stability and maintainability of the project:

1. Fix Non-Regression Tests
2. Code Cleanup
3. Increased Code Quality

Related issues

Fixes:

Manual testing steps

1. Run non regression test on this branch

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dbcee30
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4945c0d8-324e-4a33-b443-c160026e0e7f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8aec07a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7789bbce-e8ac-4e93-b91d-269225414a32

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ab9f10a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd1553e0-97a2-47e6-88af-5c1ff9d6049d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[cortisiko]

small feedback to remove comment

[cortisiko]

✅ ✅

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1880ab5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc31d33a-f468-4eb4-96be-b49a6bb29861

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
64.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[salimtb]

non regression test: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2a66d74-5960-4642-a292-aca9b42586ec