Skip to content

Commit

Permalink
fix: fix non regression tests
Browse files Browse the repository at this point in the history
  • Loading branch information
salimtb committed Oct 14, 2024
1 parent 247686d commit 17636b4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ const createStyles = (colors) =>
addRpcNameButton: {
alignSelf: 'center',
paddingHorizontal: 16,
paddingVertical: 16,
width: '100%',
paddingTop: 160,
},
rpcMenu: {
paddingHorizontal: 16,
Expand Down Expand Up @@ -1769,6 +1768,7 @@ export class NetworkSettings extends PureComponent {
autoCapitalize={'none'}
autoCorrect={false}
value={nickname}
editable={!this.isAnyModalVisible()}
onChangeText={this.onNicknameChange}
placeholder={strings('app_settings.network_name_placeholder')}
placeholderTextColor={colors.text.muted}
Expand Down Expand Up @@ -1877,6 +1877,7 @@ export class NetworkSettings extends PureComponent {
autoCapitalize={'none'}
autoCorrect={false}
value={chainId}
editable={!this.isAnyModalVisible()}
onChangeText={this.onChainIDChange}
onBlur={() => {
this.validateChainId();
Expand All @@ -1901,6 +1902,7 @@ export class NetworkSettings extends PureComponent {
autoCapitalize={'none'}
autoCorrect={false}
value={ticker}
editable={!this.isAnyModalVisible()}
onChangeText={this.onTickerChange}
onBlur={() => {
this.validateSymbol();
Expand Down Expand Up @@ -1990,7 +1992,7 @@ export class NetworkSettings extends PureComponent {
{strings('app_settings.add_rpc_url')}
</Text>
</BottomSheetHeader>
<View style={styles.rpcMenu}>
<KeyboardAwareScrollView style={styles.rpcMenu}>
<Text style={styles.label}>
{strings('app_settings.network_rpc_url_label')}
</Text>
Expand Down Expand Up @@ -2044,13 +2046,13 @@ export class NetworkSettings extends PureComponent {
onPress={() => {
this.onRpcItemAdd(rpcUrlForm, rpcNameForm);
}}
width={ButtonWidthTypes.Full}
width={ButtonWidthTypes.Auto}
labelTextVariant={TextVariant.DisplayMD}
isDisabled={!!warningRpcUrl}
testID={NetworksViewSelectorsIDs.ADD_RPC_BUTTON}
/>
</View>
</View>
</KeyboardAwareScrollView>
</BottomSheet>
) : null}
{isNetworkUiRedesignEnabled() && showAddBlockExplorerForm.isVisible ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ describe(
await Assertions.checkIfVisible(Browser.browserScreenID);
await Browser.tapNetworkAvatarButtonOnBrowser();
await Assertions.checkIfNotVisible(ConnectedAccountsModal.title);
await NetworkListModal.scrollToBottomOfNetworkList();
await Assertions.checkIfVisible(NetworkListModal.testNetToggle);
},
);
Expand Down

0 comments on commit 17636b4

Please sign in to comment.