Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for batch of signature requests #11729

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Oct 10, 2024

Description

This PR addresses the issue of multiple signature popups being triggered sequentially on Mobile, which could lead to potential spam or overwhelm the user. Currently, multiple signature requests appear one after the other, even if the user accepts or rejects them. To align with the existing behavior for transactions, this PR removes signatures from the rate-limiting exclusions, ensuring that only one signature request is triggered at a time, preventing spam-like behavior until a proper queuing system is introduced on Mobile.

Related issues

Fixes: #8771

Manual testing steps

  1. go to the test dapp
  2. connect mm
  3. trigger signature x10 batch
  4. See you need to accept/reject 1 time

Screenshots/Recordings

sign.one.webm

Example of the current behaviour of batch 10 transactions:

transaction.one.webm

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Oct 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam changed the title Fix: support for batch of signature requests fix: support for batch of signature requests Oct 10, 2024
@vinistevam vinistevam marked this pull request as ready for review October 10, 2024 08:11
@vinistevam vinistevam requested a review from a team as a code owner October 10, 2024 08:11
@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 10, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Oct 10, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Oct 10, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 41a343a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a90e9dd-2c1b-4414-8f49-f00e55e18f6d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 459945c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa273372-813a-4c05-84f3-ba667d0bcc06

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.34%. Comparing base (b0ef1a7) to head (7f0ecf0).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11729      +/-   ##
==========================================
+ Coverage   54.27%   54.34%   +0.07%     
==========================================
  Files        1711     1714       +3     
  Lines       38712    39102     +390     
  Branches     4738     4843     +105     
==========================================
+ Hits        21010    21250     +240     
- Misses      16253    16367     +114     
- Partials     1449     1485      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 15, 2024

@vinistevam vinistevam added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit adfc755 Oct 15, 2024
37 checks passed
@vinistevam vinistevam deleted the fix/signature-batch-requests branch October 15, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Signatures - batch of signature requests are displayed one over the other without a way out
5 participants