Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Signatures - batch of signature requests are displayed one over the other without a way out #8771

Closed
seaona opened this issue Feb 28, 2024 · 5 comments · Fixed by #11729
Closed

[Bug]: Signatures - batch of signature requests are displayed one over the other without a way out #8771

seaona opened this issue Feb 28, 2024 · 5 comments · Fixed by #11729
Assignees
@vinistevam
Labels
release-7.34.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Feb 28, 2024

Describe the bug

Problem: for context, in Mobile there is no possibility to display several signature/tx requests and navigate to them like on Extension. Now, if I trigger a batch of 10 transactions, I see that only 1 is effectively emitted, and no matter if I accept or reject, no more transaction popup will appear.
However, on singatures it seems that this is not the case and there are 10 popup signatures one over the other one, and no matter if I accept or reject, the rest keep appearing, until all of them have been accepted/rejected

Expected behavior

It seems that this could be used as spam, so the convenient way of handling this case would be what we already do with transactions: just trigger one and that's it ? cc @bschorchit

Screenshots/Recordings

mobile-batch-tx-signature.mp4

Steps to reproduce

  1. checkout this branch of the test dapp feat: add batch and queue signature and transactions test-dapp#294
  2. go to the test dapp
  3. connect mm
  4. trigger signature x10 batch
  5. See you need to accept/reject 10 times, no way to get out

Error messages or log output

No response

Version

found in 7.17.0 but might be on other versions too

Build type

None

Device

Pixel 6

Operating system

Android

Additional context

No response

Severity

No response
@seaona seaona added type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Feb 28, 2024
@seaona seaona mentioned this issue Feb 28, 2024
Merged
@arielsbecker
Copy link

Closely related to #8251.

@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@bschorchit
Copy link

I agree we should copy the behavior we have in place for transactions until we introduce some queue to mobile

@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@bschorchit bschorchit removed the stale Issues that have not had activity in the last 90 days label Sep 4, 2024
@bschorchit bschorchit reopened this Sep 4, 2024
@bschorchit
Copy link

This is still an issue that we would like to fix

@bschorchit bschorchit removed the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Sep 4, 2024
@vinistevam vinistevam self-assigned this Oct 9, 2024
@vinistevam vinistevam mentioned this issue Oct 10, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
@vinistevam
fix: support for batch of signature requests (#11729)
adfc755 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This PR addresses the issue of multiple signature popups being triggered
sequentially on Mobile, which could lead to potential spam or overwhelm
the user. Currently, multiple signature requests appear one after the
other, even if the user accepts or rejects them. To align with the
existing behavior for transactions, this PR removes signatures from the
rate-limiting exclusions, ensuring that only one signature request is
triggered at a time, preventing spam-like behavior until a proper
queuing system is introduced on Mobile.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #8771

## **Manual testing steps**

1. go to the test dapp
2. connect mm
3. trigger signature x10 batch
4. See you need to accept/reject 1 time

## **Screenshots/Recordings**

[sign
one.webm](https://github.com/user-attachments/assets/972f8643-0e29-44a8-9ad9-1587e2bdf5d3)


Example of the current behaviour of batch 10 transactions:

[transaction
one.webm](https://github.com/user-attachments/assets/df6c1f92-3d09-4b5c-848b-07db56b9aede)


<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinistevam vinistevam

Labels
release-7.34.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Bugs by team
Status: Fixed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support for batch of signature requests MetaMask/metamask-mobile
6 participants
@gauthierpetetin @arielsbecker @cryptotavares @bschorchit @vinistevam @seaona