Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: login and password issues #1168

Merged
merged 2 commits into from
Oct 28, 2019
Merged

bugfix: login and password issues #1168

merged 2 commits into from
Oct 28, 2019

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Oct 23, 2019 •
edited
Loading

Description

Fixes #1133

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino force-pushed the bugfix/login-and-password-issues branch from ad26504 to fc5b994 Compare October 25, 2019 02:31
@estebanmino estebanmino force-pushed the bugfix/login-and-password-issues branch from fc5b994 to 7f428f1 Compare October 25, 2019 02:32
@estebanmino estebanmino reopened this Oct 25, 2019
@estebanmino estebanmino changed the title [WIP] bugfix: login and password issues bugfix: login and password issues Oct 25, 2019
@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Oct 25, 2019
brunobar79
brunobar79 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on devices that have biometrics enabled and disabled on both OS's and fixes look good

QA Passed 👍

@estebanmino estebanmino merged commit 0bc1314 into develop Oct 28, 2019
@estebanmino estebanmino deleted the bugfix/login-and-password-issues branch November 22, 2019 14:24
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix: login and password issues (#1168)
9363436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android login and password issues
3 participants
@estebanmino @brunobar79 @ibrahimtaveras00