Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android login and password issues #1133

Closed
ibrahimtaveras00 opened this issue Oct 4, 2019 · 2 comments · Fixed by #1168
Closed

Android login and password issues #1133

ibrahimtaveras00 opened this issue Oct 4, 2019 · 2 comments · Fixed by #1168
Assignees
Labels
android Android specific issue type-bug Something isn't working
Milestone

Comments

@ibrahimtaveras00
Copy link
Contributor

This is a two part issue on Android

  1. Upon going through secure your wallet flow, if you choose to take the risk, and then come back into the flow (with fingerprint disabled) you will not be asked for a password when you should be asked

steps to reproduce:

  • create a new wallet on Android
  • either go to ropsten faucet to get ETH or just send yourself ETH from a different wallet
  • wait till the txn is finished and the Secure your wallet modal pops up
  • create your password but make sure you TOGGLE OFF the option for fingerprint
  • continue and then tap X to get out and tap yes i'll take the risk
  • kill the app if you want, then relaunch
  • on browser tap the yellow alert banner to "protect your funds"
  • now go through the flow, notice you're not asked to enter in your password before seeing your seed phrase
  1. Finally, after backing up wallet by going through the flow above there are some pre-conditions now (you set up a password and you DID NOT enable fingerprint). Now kill the app and relaunch, notice you're not prompted to enter a password when you should be

steps to reproduce:

  • go through the secure your wallet flow as above, and make sure to toggle fingerprint OFF
  • after creating your password and backing up seed phrase, kill app
  • now relaunch app, you should be prompted for a password but you're not
@ibrahimtaveras00 ibrahimtaveras00 added the android Android specific issue label Oct 4, 2019
@ibrahimtaveras00 ibrahimtaveras00 added this to the v1 milestone Oct 4, 2019
@brunobar79 brunobar79 added the type-bug Something isn't working label Oct 21, 2019
@estebanmino estebanmino self-assigned this Oct 23, 2019
@estebanmino
Copy link
Contributor

I'm also seeing
image
even though I decided to "take the risk"

@brunobar79
Copy link
Contributor

brunobar79 commented Oct 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android specific issue type-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants