Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ledger sign message screen, legacy account with legacy path will push balance information outside the border of screen. #11550

Merged
merged 4 commits into from
Oct 16, 2024
+5 −4
Merged

fix: ledger sign message screen, legacy account with legacy path will push balance information outside the border of screen. #11550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0dde4f
fix: change the layout of AccountBase screen to show the label under …
dawnseeker8 Oct 1, 2024
3fda371
Merge branch 'main' into fix/11522-Ledger-sign-screen-issue
dawnseeker8 Oct 7, 2024
1848d50
Merge branch 'main' into fix/11522-Ledger-sign-screen-issue
dawnseeker8 Oct 14, 2024
cb0bc84
Merge branch 'main' into fix/11522-Ledger-sign-screen-issue
dawnseeker8 Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/component-library/components-temp/Accounts/AccountBase/AccountBase.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const styleSheet = StyleSheet.create({
justifyContent: 'flex-start',
},
accountNameLabelText: {
marginLeft: 4,
paddingHorizontal: 8,
borderWidth: 1,
borderRadius: 8,
Expand Down
8 changes: 5 additions & 3 deletions app/component-library/components-temp/Accounts/AccountBase/AccountBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,17 @@ const AccountBase = ({

<View style={styles.accountNameLabel}>
<Text variant={TextVariant.BodyMDBold}>{accountName}</Text>
{accountTypeLabel && (
</View>
{accountTypeLabel && (
<View style={styles.accountNameLabel}>
<Text
variant={TextVariant.BodySM}
variant={TextVariant.BodyMDBold}
style={styles.accountNameLabelText}
>
{strings(accountTypeLabel)}
</Text>
)}
</View>
)}
</View>
</View>
<View>
Expand Down
Loading