Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger sign message screen, legacy account with legacy path will push balance information outside the border of screen. #11550

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Oct 1, 2024

Description

When import a ledger legacy account in Metamask, and user go to click Personal Sign . sometimes the balance is out of border of the personal sign screen, please see the attached screen image for detail.

This PR fix the layout issue to put the account label below the account name so that in smaller screen, account balance will not be put out of box.

Related issues

Fixes: #11522

Manual testing steps

  1. Install MM
  2. Recover from SRP
  3. Add Ledger hardware wallet and connect Ledger 2x account
  4. Launch MM test dapp
  5. Connect Ledger legacy account on test dapp
  6. Sign Permit with account

Screenshots/Recordings

Before

image

After

image

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…the account name. this layout change will fix the balance is outside the box in smaller iphone screen.
@dawnseeker8 dawnseeker8 added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-hardware-wallets labels Oct 1, 2024
@dawnseeker8 dawnseeker8 requested review from a team as code owners October 1, 2024 18:11
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c0dde4f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0940907-6bf5-41b7-b772-30b7235f0549

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3fda371
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a62f7a4-57b9-41d7-8213-45d02e2a82ec

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a figma link for this? the margin change may not be approved by design

@dawnseeker8
Copy link
Contributor Author

Do you have a figma link for this? the margin change may not be approved by design

I am waiting for @eriknson to approve on the layout change.

@SayaGT
Copy link

SayaGT commented Oct 14, 2024

LGTM! We can go ahead with these changes as they leverage an existing pattern. These designs will soon be replaced with the new confirmation designs. You can find the relevant Figma here.

Copy link

sonarcloud bot commented Oct 15, 2024

@dawnseeker8 dawnseeker8 added this pull request to the merge queue Oct 16, 2024
@vivek-consensys vivek-consensys added the QA Passed A successful QA run through has been done label Oct 16, 2024
Merged via the queue into main with commit 3fc95b2 Oct 16, 2024
40 checks passed
@dawnseeker8 dawnseeker8 deleted the fix/11522-Ledger-sign-screen-issue branch October 16, 2024 08:49
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-accounts team-hardware-wallets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Balance text not visible when signing with Ledger (legacy) account
5 participants