Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forkdelta.app #1023

Merged
merged 6 commits into from
Aug 26, 2019
Merged

Fix forkdelta.app #1023

merged 6 commits into from
Aug 26, 2019

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Aug 24, 2019

Forkdelta was crashing the browser on iOS & Android because of a request to a non standard protocol. That fix was included in the latest version of react-native-web3-webview and now it works correctly.

Fixes #918

Android: https://recordit.co/6qjq9jDMSc
iOS: http://recordit.co/lLJ6EGAh4k

@brunobar79 brunobar79 changed the title Fix forkdelta Fix forkdelta.app Aug 24, 2019
@brunobar79 brunobar79 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 24, 2019
@ibrahimtaveras00
Copy link
Contributor

Fix looks good on both OS's, QA Passed 👍

Seen here = http://recordit.co/yml7M4Zem4

@brunobar79 brunobar79 merged commit 2e78209 into develop Aug 26, 2019
@estebanmino estebanmino deleted the fix-forkdelta branch February 4, 2020 15:57
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* bump react-native-web3-webview

* update package-lock.json

* fix forkdelta.app

* fix

* fix dep bs

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forkdelta crashing the browser and not working
3 participants