Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forkdelta crashing the browser and not working #918

Closed
AboShanab opened this issue Jul 24, 2019 · 5 comments · Fixed by #1023
Closed

Forkdelta crashing the browser and not working #918

AboShanab opened this issue Jul 24, 2019 · 5 comments · Fixed by #1023
Assignees

Comments

@AboShanab
Copy link

As the title, Forkdelta is crashing the browser and there's no abillity to use it on Android 9 (MetaMask version is 0.2.1)

Screenshot_1

@crvanderhorst
Copy link

Same issue on iPhone 6, exact same issue.

@bitpshr
Copy link
Contributor

bitpshr commented Aug 23, 2019

For some reason, ForkDelta is redirecting users to a u2f:// URL during sign in on mobile, which blows up the WebView we use. I'm not sure we can gracefully handle this; we can hide the error, but we can't easily handle the u2f:// protocol. I tried searching the ForkDelta code and couldn't find any u2f:// reference, which is a little weird.

@brunobar79
Copy link
Contributor

brunobar79 commented Aug 24, 2019

@bitpshr I've fixed this on [email protected] (just published to npm). Now I'm seeing a provider issue where

window.web3.eth.getAccounts((e,a) => console.log(e, a)); 

returns an empty array in mobile

null []

while it works fine in the extension:

null ["0xbB5c363081BA1c856537253920b7B2D098D701c3"]

@brunobar79
Copy link
Contributor

NVM, just fixed it:
Screen Shot 2019-08-23 at 9 12 38 PM

@AboShanab
Copy link
Author

@brunobar79 Well done!

hesterbruikman added a commit that referenced this issue May 12, 2023
hesterbruikman added a commit that referenced this issue May 15, 2023
* Update en.json with eth_sign

Copy for #918

* Update locales/languages/en.json

Co-authored-by: Nicolas MASSART <[email protected]>

---------

Co-authored-by: Nicolas MASSART <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants