Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snaps packages #21908

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Bump snaps packages #21908

merged 5 commits into from
Nov 22, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 21, 2023

Description

Bump snaps packages to latest.

Summary of changes in the snaps deps:

  • Fix a few issues with passing non-JSON-serializable values
  • Block wallet_revokePermissions
  • Add row and address component

This PR also adds functionality to support the addition of the row and address components.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1570

Manual testing steps

  1. Go to https://metamask.github.io/snaps/test-snaps/latest
  2. Install the transaction insight snap
  3. Click the send transaction button on the dapp
  4. Click the tx insight tab
  5. See that the snap uses rows for its formatting

Screenshots/Recordings

Screenshot 2023-11-21 at 12 51 34
Screen.Recording.2023-11-21.at.13.01.56.mov

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Nov 21, 2023
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 21, 2023
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/[email protected]

@FrederikBolding FrederikBolding marked this pull request as ready for review November 21, 2023 12:03
@FrederikBolding FrederikBolding requested review from a team as code owners November 21, 2023 12:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yarn.lock Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [1fd74d5]
Page Load Metrics (600 ± 272 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8612798115
domContentLoaded6811887136
load811335600566272
domInteractive6811887136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 306 Bytes (0.01%)
  • ui: 8.14 KiB (0.12%)
  • common: 50.99 KiB (1.13%)

@bowensanders
Copy link
Contributor

✅ QA Passes

@FrederikBolding FrederikBolding merged commit f01b593 into develop Nov 22, 2023
66 of 67 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v21 branch November 22, 2023 09:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@metamaskbot metamaskbot added the release-11.7.0 Issue or pull request that will be included in release 11.7.0 label Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.7.0 Issue or pull request that will be included in release 11.7.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants