Skip to content

Commit

Permalink
Bump snaps packages (#21908)
Browse files Browse the repository at this point in the history
## **Description**

Bump snaps packages to latest.

Summary of changes in the snaps deps:

- Fix a few issues with passing non-JSON-serializable values
- Block `wallet_revokePermissions`
- **Add `row` and `address` component**

This PR also adds functionality to support the addition of the `row` and
`address` components.

## **Related issues**

Fixes: MetaMask/MetaMask-planning#1570


## **Manual testing steps**

1. Go to https://metamask.github.io/snaps/test-snaps/latest
2. Install the transaction insight snap
3. Click the send transaction button on the dapp
4. Click the tx insight tab
5. See that the snap uses rows for its formatting

## **Screenshots/Recordings**

<img width="364" alt="Screenshot 2023-11-21 at 12 51 34"
src="https://github.com/MetaMask/metamask-extension/assets/1561200/5360f85d-08a6-4a2d-85a8-c2e5331a78fa">


https://github.com/MetaMask/metamask-extension/assets/1561200/c2bcdbec-a9ac-47e4-9f5f-d097d696e955

---------

Co-authored-by: legobeat <[email protected]>
  • Loading branch information
FrederikBolding and legobeat authored Nov 22, 2023
1 parent 1984f31 commit f01b593
Show file tree
Hide file tree
Showing 12 changed files with 286 additions and 178 deletions.
8 changes: 4 additions & 4 deletions builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ buildTypes:
- SEGMENT_WRITE_KEY_REF: SEGMENT_PROD_WRITE_KEY
- ALLOW_LOCAL_SNAPS: false
- REQUIRE_SNAPS_ALLOWLIST: true
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.0/index.html
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.1/index.html
- KEYRING_SNAPS_REGISTRY_URL: https://metamask.github.io/keyring-snaps-registry/prod/registry.json
# Main build uses the default browser manifest
manifestOverrides: false
Expand Down Expand Up @@ -61,7 +61,7 @@ buildTypes:
- SEGMENT_FLASK_WRITE_KEY
- ALLOW_LOCAL_SNAPS: true
- REQUIRE_SNAPS_ALLOWLIST: false
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.0/index.html
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.1/index.html
- SUPPORT_LINK: https://metamask-flask.zendesk.com/hc
- SUPPORT_REQUEST_LINK: https://metamask-flask.zendesk.com/hc/en-us/requests/new
- INFURA_ENV_KEY_REF: INFURA_FLASK_PROJECT_ID
Expand All @@ -81,7 +81,7 @@ buildTypes:
- SEGMENT_FLASK_WRITE_KEY
- ALLOW_LOCAL_SNAPS: true
- REQUIRE_SNAPS_ALLOWLIST: false
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.0/index.html
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.1/index.html
- SUPPORT_LINK: https://metamask-flask.zendesk.com/hc
- SUPPORT_REQUEST_LINK: https://metamask-flask.zendesk.com/hc/en-us/requests/new
- INFURA_ENV_KEY_REF: INFURA_FLASK_PROJECT_ID
Expand All @@ -101,7 +101,7 @@ buildTypes:
- SEGMENT_WRITE_KEY_REF: SEGMENT_MMI_WRITE_KEY
- ALLOW_LOCAL_SNAPS: false
- REQUIRE_SNAPS_ALLOWLIST: true
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.0/index.html
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.consensys.io/3.4.1/index.html
- MMI_CONFIGURATION_SERVICE_URL: https://configuration.metamask-institutional.io/v2/configuration/default
- SUPPORT_LINK: https://mmi-support.zendesk.com/hc/en-us
- SUPPORT_REQUEST_LINK: https://mmi-support.zendesk.com/hc/en-us/requests/new
Expand Down
64 changes: 37 additions & 27 deletions lavamoat/browserify/desktop/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1898,6 +1898,26 @@
"punycode": true
}
},
"@metamask/phishing-warning>@metamask/object-multiplex": {
"globals": {
"console.warn": true
},
"packages": {
"@metamask/phishing-warning>@metamask/object-multiplex>readable-stream": true,
"pump>once": true
}
},
"@metamask/phishing-warning>@metamask/object-multiplex>readable-stream": {
"packages": {
"browserify>browser-resolve": true,
"browserify>buffer": true,
"browserify>process": true,
"browserify>string_decoder": true,
"pumpify>inherits": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@metamask/phishing-warning>eth-phishing-detect": {
"packages": {
"eslint>optionator>fast-levenshtein": true
Expand Down Expand Up @@ -1996,16 +2016,6 @@
"webpack>events": true
}
},
"@metamask/providers>@metamask/object-multiplex": {
"globals": {
"console.warn": true
},
"packages": {
"end-of-stream": true,
"pump>once": true,
"readable-stream": true
}
},
"@metamask/providers>@metamask/rpc-errors": {
"packages": {
"@metamask/utils": true,
Expand Down Expand Up @@ -2129,24 +2139,24 @@
"packages": {
"@metamask/base-controller": true,
"@metamask/permission-controller": true,
"@metamask/phishing-warning>@metamask/object-multiplex": true,
"@metamask/post-message-stream": true,
"@metamask/providers>@metamask/json-rpc-engine": true,
"@metamask/providers>@metamask/object-multiplex": true,
"@metamask/providers>@metamask/rpc-errors": true,
"@metamask/snaps-controllers>@xstate/fsm": true,
"@metamask/snaps-controllers>concat-stream": true,
"@metamask/snaps-controllers>get-npm-tarball-url": true,
"@metamask/snaps-controllers>gunzip-maybe": true,
"@metamask/snaps-controllers>json-rpc-middleware-stream": true,
"@metamask/snaps-controllers>nanoid": true,
"@metamask/snaps-controllers>readable-stream": true,
"@metamask/snaps-controllers>readable-web-to-node-stream": true,
"@metamask/snaps-controllers>tar-stream": true,
"@metamask/snaps-rpc-methods": true,
"@metamask/snaps-sdk": true,
"@metamask/snaps-utils": true,
"@metamask/snaps-utils>@metamask/snaps-registry": true,
"@metamask/utils": true,
"stream-browserify": true
"@metamask/utils": true
}
},
"@metamask/snaps-controllers-flask>nanoid": {
Expand All @@ -2156,24 +2166,13 @@
},
"@metamask/snaps-controllers>concat-stream": {
"packages": {
"@metamask/snaps-controllers>concat-stream>readable-stream": true,
"@metamask/snaps-controllers>readable-stream": true,
"browserify>buffer": true,
"browserify>concat-stream>typedarray": true,
"pumpify>inherits": true,
"terser>source-map-support>buffer-from": true
}
},
"@metamask/snaps-controllers>concat-stream>readable-stream": {
"packages": {
"browserify>browser-resolve": true,
"browserify>buffer": true,
"browserify>process": true,
"browserify>string_decoder": true,
"pumpify>inherits": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@metamask/snaps-controllers>gunzip-maybe": {
"packages": {
"@metamask/snaps-controllers>gunzip-maybe>browserify-zlib": true,
Expand Down Expand Up @@ -2258,8 +2257,8 @@
"setTimeout": true
},
"packages": {
"@metamask/snaps-controllers>concat-stream>readable-stream": true,
"@metamask/snaps-controllers>json-rpc-middleware-stream>@metamask/safe-event-emitter": true
"@metamask/snaps-controllers>json-rpc-middleware-stream>@metamask/safe-event-emitter": true,
"@metamask/snaps-controllers>readable-stream": true
}
},
"@metamask/snaps-controllers>json-rpc-middleware-stream>@metamask/safe-event-emitter": {
Expand All @@ -2275,6 +2274,17 @@
"crypto.getRandomValues": true
}
},
"@metamask/snaps-controllers>readable-stream": {
"packages": {
"browserify>browser-resolve": true,
"browserify>buffer": true,
"browserify>process": true,
"browserify>string_decoder": true,
"pumpify>inherits": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@metamask/snaps-controllers>readable-web-to-node-stream": {
"packages": {
"@metamask/snaps-controllers>readable-web-to-node-stream>readable-stream": true
Expand Down
64 changes: 37 additions & 27 deletions lavamoat/browserify/flask/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1898,6 +1898,26 @@
"punycode": true
}
},
"@metamask/phishing-warning>@metamask/object-multiplex": {
"globals": {
"console.warn": true
},
"packages": {
"@metamask/phishing-warning>@metamask/object-multiplex>readable-stream": true,
"pump>once": true
}
},
"@metamask/phishing-warning>@metamask/object-multiplex>readable-stream": {
"packages": {
"browserify>browser-resolve": true,
"browserify>buffer": true,
"browserify>process": true,
"browserify>string_decoder": true,
"pumpify>inherits": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@metamask/phishing-warning>eth-phishing-detect": {
"packages": {
"eslint>optionator>fast-levenshtein": true
Expand Down Expand Up @@ -2042,16 +2062,6 @@
"webpack>events": true
}
},
"@metamask/providers>@metamask/object-multiplex": {
"globals": {
"console.warn": true
},
"packages": {
"end-of-stream": true,
"pump>once": true,
"readable-stream": true
}
},
"@metamask/providers>@metamask/rpc-errors": {
"packages": {
"@metamask/utils": true,
Expand Down Expand Up @@ -2175,24 +2185,24 @@
"packages": {
"@metamask/base-controller": true,
"@metamask/permission-controller": true,
"@metamask/phishing-warning>@metamask/object-multiplex": true,
"@metamask/post-message-stream": true,
"@metamask/providers>@metamask/json-rpc-engine": true,
"@metamask/providers>@metamask/object-multiplex": true,
"@metamask/providers>@metamask/rpc-errors": true,
"@metamask/snaps-controllers>@xstate/fsm": true,
"@metamask/snaps-controllers>concat-stream": true,
"@metamask/snaps-controllers>get-npm-tarball-url": true,
"@metamask/snaps-controllers>gunzip-maybe": true,
"@metamask/snaps-controllers>json-rpc-middleware-stream": true,
"@metamask/snaps-controllers>nanoid": true,
"@metamask/snaps-controllers>readable-stream": true,
"@metamask/snaps-controllers>readable-web-to-node-stream": true,
"@metamask/snaps-controllers>tar-stream": true,
"@metamask/snaps-rpc-methods": true,
"@metamask/snaps-sdk": true,
"@metamask/snaps-utils": true,
"@metamask/snaps-utils>@metamask/snaps-registry": true,
"@metamask/utils": true,
"stream-browserify": true
"@metamask/utils": true
}
},
"@metamask/snaps-controllers-flask>nanoid": {
Expand All @@ -2202,24 +2212,13 @@
},
"@metamask/snaps-controllers>concat-stream": {
"packages": {
"@metamask/snaps-controllers>concat-stream>readable-stream": true,
"@metamask/snaps-controllers>readable-stream": true,
"browserify>buffer": true,
"browserify>concat-stream>typedarray": true,
"pumpify>inherits": true,
"terser>source-map-support>buffer-from": true
}
},
"@metamask/snaps-controllers>concat-stream>readable-stream": {
"packages": {
"browserify>browser-resolve": true,
"browserify>buffer": true,
"browserify>process": true,
"browserify>string_decoder": true,
"pumpify>inherits": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@metamask/snaps-controllers>gunzip-maybe": {
"packages": {
"@metamask/snaps-controllers>gunzip-maybe>browserify-zlib": true,
Expand Down Expand Up @@ -2304,8 +2303,8 @@
"setTimeout": true
},
"packages": {
"@metamask/snaps-controllers>concat-stream>readable-stream": true,
"@metamask/snaps-controllers>json-rpc-middleware-stream>@metamask/safe-event-emitter": true
"@metamask/snaps-controllers>json-rpc-middleware-stream>@metamask/safe-event-emitter": true,
"@metamask/snaps-controllers>readable-stream": true
}
},
"@metamask/snaps-controllers>json-rpc-middleware-stream>@metamask/safe-event-emitter": {
Expand All @@ -2321,6 +2320,17 @@
"crypto.getRandomValues": true
}
},
"@metamask/snaps-controllers>readable-stream": {
"packages": {
"browserify>browser-resolve": true,
"browserify>buffer": true,
"browserify>process": true,
"browserify>string_decoder": true,
"pumpify>inherits": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@metamask/snaps-controllers>readable-web-to-node-stream": {
"packages": {
"@metamask/snaps-controllers>readable-web-to-node-stream>readable-stream": true
Expand Down
Loading

0 comments on commit f01b593

Please sign in to comment.