Skip to content

deps: replace eth-json-rpc-middleware with @metamask/eth-json-rpc-provider #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023
Merged

deps: replace eth-json-rpc-middleware with @metamask/eth-json-rpc-provider #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c1199
deps: replace eth-json-rpc-middleware with @metamask/eth-json-rpc-pro…
legobeat Jul 12, 2023
96bb1ed
Merge branch 'main' into deps-eth-json-rpc-middleware
legobeat Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"test:watch": "jest --watch"
},
"dependencies": {
"@metamask/utils": "^3.0.1",
"eth-json-rpc-middleware": "^9.0.0",
"@metamask/eth-json-rpc-provider": "^1.0.0",
"@metamask/utils": "^3.6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can take the chance to update @metamask/utils to ^6.2.0 as we just use createProjectLogger, createModuleLogger?

Copy link
Contributor Author

@legobeat legobeat Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the change is coming up, but let's do that separately.

BTW we could do ^5.0.2 at best without making that bump a breaking change, due to engines.node being >=16.0.0 since 6.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#83

"eth-rpc-errors": "^4.0.3",
"json-rpc-engine": "^6.1.0",
"node-fetch": "^2.6.7"
Expand All @@ -39,7 +39,7 @@
"@metamask/eslint-config-nodejs": "^9.0.0",
"@metamask/eslint-config-typescript": "^9.0.1",
"@types/jest": "^26.0.13",
"@types/node": "^17.0.23",
"@types/node": "^14.18.53",
"@types/node-fetch": "^2.6.1",
"@typescript-eslint/eslint-plugin": "^4.21.0",
"@typescript-eslint/parser": "^4.21.0",
Expand Down Expand Up @@ -68,9 +68,7 @@
},
"lavamoat": {
"allowScripts": {
"@lavamoat/preinstall-always-fail": false,
"eth-json-rpc-middleware>eth-sig-util>ethereumjs-util>ethereum-cryptography>keccak": true,
"eth-json-rpc-middleware>eth-sig-util>ethereumjs-util>ethereum-cryptography>secp256k1": true
"@lavamoat/preinstall-always-fail": false
}
}
}
8 changes: 4 additions & 4 deletions src/create-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
import { JsonRpcEngine } from 'json-rpc-engine';
import { providerFromEngine } from 'eth-json-rpc-middleware';
import type { SafeEventEmitterProvider } from 'eth-json-rpc-middleware';
import { providerFromEngine } from '@metamask/eth-json-rpc-provider';
import type { SafeEventEmitterProvider } from '@metamask/eth-json-rpc-provider';
import {
createInfuraMiddleware,
CreateInfuraMiddlewareOptions,
} from './create-infura-middleware';

/**
* Creates a provider (as defined in
* [`eth-json-rpc-middleware`](https://github.com/MetaMask/eth-json-rpc-middleware)
* [`eth-json-rpc-provider`](https://github.com/MetaMask/eth-json-rpc-provider)
* which is preloaded with middleware specialized for interfacing with Infura
* JSON-RPC endpoints.
*
* @param opts - Options to {@link createInfuraMiddleware}.
* @returns The provider as returned by `providerFromEngine` (a part of
* [`eth-json-rpc-middleware`](https://github.com/MetaMask/eth-json-rpc-middleware)).
* [`eth-json-rpc-provider`](https://github.com/MetaMask/eth-json-rpc-provider)).
*/
export function createProvider(
opts: CreateInfuraMiddlewareOptions,
Expand Down
Loading