Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: replace eth-json-rpc-middleware with @metamask/eth-json-rpc-provider #82

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

legobeat
Copy link
Contributor

eth-json-rpc-middleware has been split into @metamask/eth-json-rpc-middleware and @metamask/eth-json-rpc-provider. Only the parts from the latter is used here.

Also drop @types/node to highest version of lowest currently supported node major 14.

@legobeat legobeat changed the title deps: replace eth-json-rpc-middleware with @metamaask/eth-json-rpc-provider deps: replace eth-json-rpc-middleware with @metamask/eth-json-rpc-provider Jul 12, 2023
@legobeat legobeat requested a review from a team July 12, 2023 11:23
@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/eth-json-rpc-provider 1.0.0 None +0 20.5 kB gudahtt
@types/node 17.0.23...14.18.53 None +0/-0 1.58 MB types
@metamask/utils 3.0.1...3.6.0 None +1/-1 425 kB metamaskbot

🚮 Removed packages: [email protected]

@socket-security
Copy link

socket-security bot commented Jul 12, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat requested review from a team July 12, 2023 11:24
@legobeat
Copy link
Contributor Author

legobeat commented Jul 12, 2023

@SocketSecurity ignore @metamask/[email protected]

no author data OK

@legobeat legobeat marked this pull request as ready for review July 12, 2023 11:24
@legobeat legobeat requested a review from mikesposito July 12, 2023 11:39
"@metamask/utils": "^3.0.1",
"eth-json-rpc-middleware": "^9.0.0",
"@metamask/eth-json-rpc-provider": "^1.0.0",
"@metamask/utils": "^3.6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can take the chance to update @metamask/utils to ^6.2.0 as we just use createProjectLogger, createModuleLogger?

Copy link
Contributor Author

@legobeat legobeat Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the change is coming up, but let's do that separately.

BTW we could do ^5.0.2 at best without making that bump a breaking change, due to engines.node being >=16.0.0 since 6.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#83

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 5e4245e into MetaMask:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants