Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace await-semaphore with async-mutex. #33

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 2, 2021

We've had issues with await-semaphore causing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned.

async-mutex is more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.

We've had issues with await-semaphore causing TypeScript errors due to
mistakes in how it is packaged. It generally seems to be abandoned.

async-mutex is more actively maintained, has better documentation and
test coverage, and is API-compatible for our usage.
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 720bae6 into main Feb 3, 2021
@Gudahtt Gudahtt deleted the replace-await-semaphore branch February 3, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants