Replace await-semaphore with async-mutex
#334
Merged
+7
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll leave this in draft until MetaMask/eth-json-rpc-filters#33 is merged and published. Until we purge this package from our dependency tree entirely, the same TypeScript error we ran into might crop up again. Edit: This now depends upon #336 |
Gudahtt
force-pushed
the
replace-await-semaphore
branch
from
55a14c9 to
0ec62ea
Compare
Gudahtt
changed the base branch from
develop
to
update-eth-json-rpc-filters-lockfile
Base automatically changed from
update-eth-json-rpc-filters-lockfile
to
develop
February 5, 2021 18:52
Gudahtt
force-pushed
the
replace-await-semaphore
branch
from
0ec62ea to
edc5299
Compare
We've had issues with `await-semaphore` causing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned. `async-mutex` is more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.
Gudahtt
force-pushed
the
replace-await-semaphore
branch
from
edc5299 to
40c9e38
Compare
rekmarks
approved these changes
Feb 5, 2021
rickycodes
added a commit
that referenced
this pull request
Feb 18, 2021
…ba into feature/migrate-to-etherscan * 'feature/migrate-to-etherscan' of github.com:MetaMask/gaba: Update `sinon` and `@types/sinon` to latest versions (#352) Fix `tsconfig.json` indentation (#355) Replace `fetch-mock` with `nock` (#340) Update `ethereumjs-wallet` from v0.6.5 to v1.0.1 (#347) Add `babel-runtime` dependency required by `ethjs-query` (#341) Update `@metamask/eslint-config` from v3 to v4.1.0 (#344) Add `docs` to list of ignored eslint patterns (#345) Update `uuid` from `v3.3.3` to `v8.3.2` (#346) Update approval controller test import (#339) Add Dependabot config (#343) Update `typedoc` (#342) Remove unused test module (#338) Replace `await-semaphore` with `async-mutex` (#334) Update `eth-json-rpc-filters` in lockfile (#336)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
We've had issues with `await-semaphore` causing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned. `async-mutex` is more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
We've had issues with `await-semaphore` causing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned. `async-mutex` is more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had issues with
await-semaphorecausing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned.async-mutexis more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.