Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchTokenMetadata in token service (#812)" #824

Merged
merged 1 commit into from
May 11, 2022
Merged

Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchTokenMetadata in token service (#812)" #824

merged 1 commit into from
May 11, 2022

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented May 11, 2022 •
edited
Loading

Reverts this commit so that we can cut a patch release for this package (v29.0.1). Will re-add this commit after the release is cut/published.

@adonesky1
Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchToken…
9b3be92 
…Metadata in token service (#812)"

This reverts commit d4030cf.
@adonesky1 adonesky1 requested a review from a team as a code owner May 11, 2022 18:16
@adonesky1 adonesky1 requested review from Cal-L and Gudahtt May 11, 2022 18:17
Cal-L
Cal-L approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gudahtt
Gudahtt approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have reviewed the other changes on main and I agree that they seem unaffected by this revert.

@adonesky1 adonesky1 merged commit a25d909 into main May 11, 2022
@adonesky1 adonesky1 deleted the revert-fetchTokenMetaData-breaking-change branch May 11, 2022 18:27
Gudahtt added a commit that referenced this pull request May 12, 2022
@Gudahtt
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
2063d9b 
…tchTokenMetadata in token service (#812)" (#824)"

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
@Gudahtt Gudahtt mentioned this pull request May 12, 2022
Merged
Gudahtt added a commit that referenced this pull request May 12, 2022
@Gudahtt
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
865116c 
…tchTokenMetadata in token service (#812)" (#824)" (#827)

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchToken…
1d9fe9d 
…Metadata in token service (#812)" (#824)

This reverts commit d4030cf.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
33c2550 
…tchTokenMetadata in token service (#812)" (#824)" (#827)

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchToken…
1d0922e 
…Metadata in token service (#812)" (#824)

This reverts commit d4030cf.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
eca4f80 
…tchTokenMetadata in token service (#812)" (#824)" (#827)

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adonesky1 @Gudahtt @Cal-L