Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/168.0.0 #4469

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Release/168.0.0 #4469

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd01cbb
Initialize Release 168.0.0
Prithpal-Sooriya Jun 27, 2024
7b95eaa
Update Release 168.0.0
Prithpal-Sooriya Jun 27, 2024
434327f
fix changelog lint
Prithpal-Sooriya Jun 27, 2024
801d009
update changed packages from minor to patch
Prithpal-Sooriya Jun 27, 2024
1898a91
docs: update changelog
Prithpal-Sooriya Jun 27, 2024
3d08207
Merge branch 'main' into release/168.0.0
Prithpal-Sooriya Jun 27, 2024
89fbf86
Update packages/notification-services-controller/CHANGELOG.md
Prithpal-Sooriya Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/notification-services-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.1.1]

### Added

- export `defaultState` for `NotificationServicesController` and `NotificationServicesPushController`. ([#4441](https://github.com/MetaMask/core/pull/4441))

- export `NOTIFICATION_CHAINS_ID` which is a const-asserted version of `NOTIFICATION_CHAINS` ([#4441](https://github.com/MetaMask/core/pull/4441))

- export `NOTIFICATION_NETWORK_CURRENCY_NAME` and `NOTIFICATION_NETWORK_CURRENCY_SYMBOL`. Allows consistent currency names and symbols for supported notification services ([#4441](https://github.com/MetaMask/core/pull/4441))

- added `isPushIntegrated` optional env property (defaults to true) ([#4441](https://github.com/MetaMask/core/pull/4441))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had one last addition for clarity:

Suggested change
- added `isPushIntegrated` optional env property (defaults to true) ([#4441](https://github.com/MetaMask/core/pull/4441))
- add `isPushIntegrated` as an optional env property in the `NotificationServicesController` constructor (defaults to true) ([#4441](https://github.com/MetaMask/core/pull/4441))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly question - but do we have a changelog "best practices" doc or notes? E.g. past tense, be descriptive, etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that's a good point. Closest thing we have is this: https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md (especially section 5), but it could definitely be more comprehensive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


### Fixed

- `NotificationServicesPushController` - removed global `self` calls for mobile compatibility ([#4441](https://github.com/MetaMask/core/pull/4441))

## [0.1.0]

### Added

- Initial release

[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected]
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected]
[0.1.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]
[0.1.0]: https://github.com/MetaMask/core/releases/tag/@metamask/[email protected]
6 changes: 3 additions & 3 deletions packages/notification-services-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/notification-services-controller",
"version": "0.1.0",
"version": "0.1.1",
"description": "Manages New MetaMask decentralized Notification system",
"keywords": [
"MetaMask",
Expand Down Expand Up @@ -45,7 +45,7 @@
"@metamask/base-controller": "^6.0.0",
"@metamask/controller-utils": "^11.0.0",
"@metamask/keyring-controller": "^17.1.0",
"@metamask/profile-sync-controller": "^0.1.0",
"@metamask/profile-sync-controller": "^0.1.1",
"bignumber.js": "^4.1.0",
"contentful": "^10.3.6",
"firebase": "^10.11.0",
Expand All @@ -68,7 +68,7 @@
},
"peerDependencies": {
"@metamask/keyring-controller": "^17.0.0",
"@metamask/profile-sync-controller": "^0.1.0"
"@metamask/profile-sync-controller": "^0.1.1"
},
"engines": {
"node": "^18.18 || >=20"
Expand Down
13 changes: 12 additions & 1 deletion packages/profile-sync-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.1.1]

### Added

- export `defaultState` for `AuthenticationController` and `UserStorageController`. ([#4441](https://github.com/MetaMask/core/pull/4441))

### Changed

- `AuthType`, `Env`, `Platform` are changed from const enums to enums ([#4441](https://github.com/MetaMask/core/pull/4441))

## [0.1.0]

### Added

- Initial release

[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected]
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected]
[0.1.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]
[0.1.0]: https://github.com/MetaMask/core/releases/tag/@metamask/[email protected]
2 changes: 1 addition & 1 deletion packages/profile-sync-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/profile-sync-controller",
"version": "0.1.0",
"version": "0.1.1",
"description": "The profile sync helps developers synchronize data across multiple clients and devices in a privacy-preserving way. All data saved in the user storage database is encrypted client-side to preserve privacy. The user storage provides a modular design, giving developers the flexibility to construct and manage their storage spaces in a way that best suits their needs",
"keywords": [
"MetaMask",
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3255,7 +3255,7 @@ __metadata:
"@metamask/base-controller": ^6.0.0
"@metamask/controller-utils": ^11.0.0
"@metamask/keyring-controller": ^17.1.0
"@metamask/profile-sync-controller": ^0.1.0
"@metamask/profile-sync-controller": ^0.1.1
"@types/jest": ^27.4.1
"@types/readable-stream": ^2.3.0
bignumber.js: ^4.1.0
Expand All @@ -3273,7 +3273,7 @@ __metadata:
uuid: ^8.3.2
peerDependencies:
"@metamask/keyring-controller": ^17.0.0
"@metamask/profile-sync-controller": ^0.1.0
"@metamask/profile-sync-controller": ^0.1.1
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3466,7 +3466,7 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/profile-sync-controller@^0.1.0, @metamask/profile-sync-controller@workspace:packages/profile-sync-controller":
"@metamask/profile-sync-controller@^0.1.1, @metamask/profile-sync-controller@workspace:packages/profile-sync-controller":
version: 0.0.0-use.local
resolution: "@metamask/profile-sync-controller@workspace:packages/profile-sync-controller"
dependencies:
Expand Down
Loading