Release/168.0.0 #4469
Merged
Release/168.0.0 #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
added
the
team-notifications
MajorLift
reviewed
Jun 27, 2024
Prithpal-Sooriya
force-pushed
the
release/168.0.0
branch
from
d01a985
to
801d009
Compare
MajorLift
reviewed
Jun 27, 2024
MajorLift
reviewed
Jun 27, 2024
Prithpal-Sooriya
force-pushed
the
release/168.0.0
branch
from
013e2f7
to
1898a91
Compare
adds more comprehensive changelog for these changes
matteoscurati
previously approved these changes
Jun 27, 2024
MajorLift
reviewed
Jun 27, 2024
|
|
||
| - export `NOTIFICATION_NETWORK_CURRENCY_NAME` and `NOTIFICATION_NETWORK_CURRENCY_SYMBOL`. Allows consistent currency names and symbols for supported notification services ([#4441](https://github.com/MetaMask/core/pull/4441)) | ||
|
|
||
| - added `isPushIntegrated` optional env property (defaults to true) ([#4441](https://github.com/MetaMask/core/pull/4441)) |
There was a problem hiding this comment.
Looks good! Just had one last addition for clarity:
Suggested change
| - added `isPushIntegrated` optional env property (defaults to true) ([#4441](https://github.com/MetaMask/core/pull/4441)) | |
| - add `isPushIntegrated` as an optional env property in the `NotificationServicesController` constructor (defaults to true) ([#4441](https://github.com/MetaMask/core/pull/4441)) |
There was a problem hiding this comment.
Silly question - but do we have a changelog "best practices" doc or notes? E.g. past tense, be descriptive, etc
There was a problem hiding this comment.
No that's a good point. Closest thing we have is this: https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md (especially section 5), but it could definitely be more comprehensive.
Co-authored-by: Jongsun Suh <[email protected]>
matteoscurati
approved these changes
Jun 27, 2024
Prithpal-Sooriya
added a commit
that referenced
this pull request
Jun 27, 2024
This reverts commit 879280b.
Prithpal-Sooriya
added a commit
that referenced
this pull request
Jun 27, 2024
Reverts #4469 We need to redo this release because the version was not set on the `package.json` and did not go out 🤦🏾 , apologies!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR create a new release for
@metamask/profile-sync-controllerto^0.2.0@metamask/notification-services-controllerto^0.2.0References
Fixes mobile integration issues.
Changelog
@metamask/profile-sync-controller@metamask/notification-services-controllerChecklist