Skip to content

Fix Windows Vulkan native runtime release build - #963

Merged
i386 merged 1 commit into
mainfrom
jd/fix-windows-vulkan-release
Jul 12, 2026
Merged

Fix Windows Vulkan native runtime release build#963
i386 merged 1 commit into
mainfrom
jd/fix-windows-vulkan-release

Conversation

@i386

@i386 i386 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

What changed

Prioritize the MinGW compiler runtime directory on PATH before configuring Windows Vulkan llama.cpp builds.

Root cause

The release job Build native runtime Windows x86_64 Vulkan built vulkan-shaders-gen.exe with the runner's MinGW GCC 14 toolchain, then launched it with the LunarG Vulkan SDK Bin directories earlier on PATH. Those directories include older GCC runtime DLLs, so Windows loaded an incompatible libstdc++ and the helper exited with STATUS_ENTRYPOINT_NOT_FOUND (0xc0000139) while generating shaders.

The compiler directory is now placed first for MinGW/MSYS/Cygwin Vulkan builds only. The Vulkan SDK remains on PATH, so glslc discovery is unchanged. Other platforms and backends are unaffected.

Impact

Windows x86_64 Vulkan native runtime packaging can generate the embedded Vulkan shaders and complete the release artifact.

Validation

  • bash -n scripts/build-llama.sh
  • shellcheck scripts/build-llama.sh
  • git diff --check
  • just check-release
  • just build

The exact Windows failure path requires a Windows runner and will be verified by PR/release CI.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Vulkan builds on MinGW, MSYS, and Cygwin environments.
    • Prevented incompatible runtime libraries from being selected during builds, improving build reliability.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 27dd7c6f-2e3f-42cb-8af0-28223b5eeb45

📥 Commits

Reviewing files that changed from the base of the PR and between 6145c9b and 30ba767.

📒 Files selected for processing (1)
  • scripts/build-llama.sh

📝 Walkthrough

Walkthrough

The Vulkan build script now prioritizes the active MinGW runtime on MinGW, MSYS, and Cygwin environments by locating g++, prepending its directory to PATH, and printing a status message.

Changes

Vulkan runtime path selection

Layer / File(s) Summary
Prioritize the MinGW runtime
scripts/build-llama.sh
Adds environment-specific PATH adjustment for Vulkan builds before sccache and CMake configuration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jd/fix-windows-vulkan-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review.

@i386
i386 marked this pull request as ready for review July 12, 2026 00:06
@github-actions
github-actions Bot requested a review from ndizazzo July 12, 2026 00:07
@i386
i386 merged commit f03520c into main Jul 12, 2026
15 of 31 checks passed
@i386
i386 deleted the jd/fix-windows-vulkan-release branch July 12, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant