Fix Windows Vulkan native runtime release build - #963
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Vulkan build script now prioritizes the active MinGW runtime on MinGW, MSYS, and Cygwin environments by locating ChangesVulkan runtime path selection
Estimated code review effort: 1 (Trivial) | ~5 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Prioritize the MinGW compiler runtime directory on
PATHbefore configuring Windows Vulkan llama.cpp builds.Root cause
The release job Build native runtime Windows x86_64 Vulkan built
vulkan-shaders-gen.exewith the runner's MinGW GCC 14 toolchain, then launched it with the LunarG Vulkan SDKBindirectories earlier onPATH. Those directories include older GCC runtime DLLs, so Windows loaded an incompatiblelibstdc++and the helper exited withSTATUS_ENTRYPOINT_NOT_FOUND(0xc0000139) while generating shaders.The compiler directory is now placed first for MinGW/MSYS/Cygwin Vulkan builds only. The Vulkan SDK remains on
PATH, soglslcdiscovery is unchanged. Other platforms and backends are unaffected.Impact
Windows x86_64 Vulkan native runtime packaging can generate the embedded Vulkan shaders and complete the release artifact.
Validation
bash -n scripts/build-llama.shshellcheck scripts/build-llama.shgit diff --checkjust check-releasejust buildThe exact Windows failure path requires a Windows runner and will be verified by PR/release CI.
Summary by CodeRabbit