fix: prefer compiler runtimes in Windows packages - #1201
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughWindows runtime dependency collection now searches the selected MinGW compiler directory before PATH and Vulkan SDK directories. Packaging resolves the compiler from configured variables or ChangesWindows runtime dependency resolution
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/package-native-runtime.sh`:
- Around line 461-470: Update the compiler lookup in the BACKEND cpu/vulkan
block to use the build-time resolved compiler path rather than passing the raw
MINGW_CXX or CXX value to command -v. Ensure wrapper or argument-containing
selections resolve correctly, and report or fail when an explicitly selected
compiler cannot be located instead of silently omitting its directory; preserve
the dependency_args search-dir addition for valid paths.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c5294c9a-cd54-4b56-9d1b-b8d0f1f0c6a9
📒 Files selected for processing (3)
scripts/package-native-runtime.shscripts/tests/test_windows_native_runtime_deps.pyscripts/windows-native-runtime-deps.py
Fixes #1160
What changed
Root cause
The collector selected the first DLL by filename, and the Vulkan SDK directory was ahead of the compiler runtime. That could package an incompatible libstdc++/libgcc/winpthread closure into the artifact.
Validation
python3 -m unittest discover -s scripts/tests -p "test*.py"(386 passed, 7 skipped)bash -n scripts/package-native-runtime.shWindows artifact loadability still needs validation on a clean Windows runner.
Summary by CodeRabbit
Bug Fixes
PATHbefore Vulkan SDK directories.Tests