Skip to content

Base doesn't have to be special #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wavewave merged 1 commit into from
Oct 30, 2024
Merged

Base doesn't have to be special #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions haskell/compile.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ def _dynamic_target_metadata_impl(actions, artifacts, dynamic_values, outputs, a
package_flag = _package_flag(arg.haskell_toolchain)
ghc_args = cmd_args()
ghc_args.add("-hide-all-packages")
ghc_args.add(package_flag, "base")

ghc_args.add(cmd_args(arg.toolchain_libs, prepend=package_flag))
ghc_args.add(cmd_args(packages_info.exposed_package_args))
Expand Down Expand Up @@ -339,10 +338,10 @@ def get_packages_info2(
],
)

# base is special and gets exposed by default
package_flag = _package_flag(haskell_toolchain)

exposed_package_args = cmd_args([package_flag, "base"])
hidden_args = [l for lib in libs.traverse() for l in lib.libs]
exposed_package_libs = cmd_args()
exposed_package_args = cmd_args()

if for_deps:
get_db = lambda l: l.deps_db
Expand Down