fix(tests): isolate lock-reap home on Windows via USERPROFILE - #2216
Merged
Conversation
The #2200 reap tests only monkeypatched HOME. On Windows expanduser("~") reads USERPROFILE, so the reaper scanned the real home and the suite failed on test-windows after Wave 2. Share _isolate_home() that sets both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows CI failed after Wave 2 with 3 failures in
tests/test_palace_locks.pyfrom #2200:test_reap_removes_stale_unlocked_locktest_reap_never_removes_a_lock_held_by_another_processtest_maybe_reap_is_throttledRoot cause: tests only set
HOME. On Windowsos.path.expanduser("~")usesUSERPROFILE, so the reaper never saw the tmp lock dir.Fix
Add
_isolate_home(monkeypatch, tmp_path)setting bothHOMEandUSERPROFILE, use it across the lock-file tests.Linux/macOS already green on develop tip after #2215; this unblocks Windows.