fix(hermes): stop second Chroma client racing the filing worker - #2215
Merged
Conversation
MemoryStack/Layer1 opened a second PersistentClient on the same palace while the Hermes provider already held one for live filing. Concurrent access corrupted local Chroma SQLite (disk I/O / Failed to get segments) and failed CI on develop after #1915. Wake-up L1 now scans the long-lived collection under the collection lock, and filing holds that lock for the full upsert. Also rewrite the RFC 001 section-4.4 docstring to avoid the internal §N jargon guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
developwent red after Wave 2 landed #1915. Two failure classes:MemoryStack/Layer1opened a secondPersistentClienton the same palace while the provider already held one for live filing. Concurrent local SQLite access produceddisk I/O error/Failed to get segments.tests/test_backend_conformance.pyused§4.4, which the internal-coordination guard forbids outside allowlisted packages.Fix
_collection_lock(no second client)_file_turnupsert_wake_up_doneso tests can wait for warm-up before readingTest plan
uv run pytest tests/test_hermes_integration.py tests/test_corpus_origin_integration.py::test_no_internal_coordination_jargon_in_source_or_tests— 59 passed