Fix/utf8 stdout windows - #1360
Closed
QuiqueMH wants to merge 1 commit into
Closed
Conversation
Two non-ASCII characters in CLI print paths break on Windows consoles whose default encoding is cp1252: * `searcher.py:363` prints `'─' * 56` as the search-result divider. cp1252 cannot encode U+2500, so `mempalace search` raises UnicodeEncodeError mid-render and exits non-zero. * `miner.py:1257` prints the `MemPalace Status —` header. cp1252 *can* encode U+2014 (em-dash), but as the single byte 0x97 which is invalid UTF-8. Parent processes reading `mempalace status` as UTF-8 fail to decode. Reconfiguring sys.stdout/stderr to UTF-8 with errors="replace" at the top of cli.py eliminates both — and the whole class of bug — without touching the offending lines (which would only fix these two incidents). reconfigure() exists on io.TextIOWrapper for Python 3.7+; the hasattr guard is belt-and-braces for any future test harness that swaps in a different stream type. errors="replace" prevents future regressions of the same shape from crashing the process. Programmatic users importing mempalace.searcher directly are unaffected — the change is scoped to the CLI entry point.
igorls
added
bug
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How to test
Checklist
python -m pytest tests/ -v)ruff check .)