Skip to content

fix(closet_llm): replace non-ASCII symbols in progress output (#1034) - #1100

Merged
igorls merged 1 commit into
MemPalace:developfrom
arnoldwender:fix/closet-llm-gbk-symbols
Jun 6, 2026
Merged

fix(closet_llm): replace non-ASCII symbols in progress output (#1034)#1100
igorls merged 1 commit into
MemPalace:developfrom
arnoldwender:fix/closet-llm-gbk-symbols

Conversation

@arnoldwender

Copy link
Copy Markdown
Contributor

What and Why

closet_llm.py prints , , and (U+2713, U+2717, U+2014) during mempalace closets regen. These characters cannot be encoded in GBK (Windows PowerShell/CMD default), causing UnicodeEncodeError on the same code path fixed in miner.py via #681.

cli.py has the same problem on the sweep error path ().

Root Cause

  • closet_llm.py:244 in dry-run banner
  • closet_llm.py:266 + in LLM-failed message
  • closet_llm.py:303 + in success message
  • cli.py:187 in sweep error message

Change Summary

Replace non-ASCII symbols with ASCII equivalents: [OK], [FAIL], [!], and -.

Test Plan

  • All 1066 existing tests pass
  • ruff check clean

Closes #1034

@arnoldwender

arnoldwender commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on latest develop. The cli.py hunk was dropped — develop already has the equivalent fix (using ERROR: instead of [!], which reads better). The closet_llm.py hunk is preserved, no logical changes.

@igorls igorls added bug Something isn't working area/cli CLI commands labels Apr 24, 2026
@arnoldwender
arnoldwender force-pushed the fix/closet-llm-gbk-symbols branch from 4d567a4 to bec1f6e Compare April 24, 2026 20:57
@arnoldwender

Copy link
Copy Markdown
Contributor Author

Friendly ping — this one's been quiet for a week. CI is green across all 6 checks (linux 3.9/3.11/3.13, windows, macos, lint), branch is merge-clean, last activity was the rebase on 2026-04-23. Happy to adjust anything if you'd like changes.

@arnoldwender

Copy link
Copy Markdown
Contributor Author

Second ping after a week. CI is green across all 6 checks (linux 3.9/3.11/3.13, windows, macos, lint), branch is merge-clean, no merge conflicts despite 100+ commits landing on develop since.

@igorls — looping you in given you've been active on the encoding cluster (#1214/#1215 merged yesterday, #1373/#1371 follow-ups in flight as #1408/#1409 today). This one is the narrow closet_llm.py slice; #1104 is the broader sweep that closes #1034. Happy to fold this into #1104 and close #1100 if that's cleaner, or rework either approach if a different direction would land better.

@arnoldwender

Copy link
Copy Markdown
Contributor Author

Friendly ping — CI is green across all platforms (Linux 3.9/3.11/3.13, macOS, Windows). #1100, #1102, #1104 are all small encoding fixes for #1034 if you want to batch them next time you're sweeping that area. Happy to rebase any of them if there's drift.

@arnoldwender

Copy link
Copy Markdown
Contributor Author

Rebased on upstream/develop (latest 1247e17, post-3.3.5 release). No logical changes — conflict-free rebase, only commit replay onto current develop. CI green pre-rebase; awaiting fresh CI run.

@arnoldwender
arnoldwender force-pushed the fix/closet-llm-gbk-symbols branch from bec1f6e to 91bf9b8 Compare May 10, 2026 10:57
@arnoldwender

Copy link
Copy Markdown
Contributor Author

Friendly ping — post-3.3.6 release this is still mergeable on upstream/develop @ f5ea021 (CI green, no conflicts). Happy to adjust anything if it would help land it.

…ace#1034)

GBK consoles (Windows PowerShell/CMD default) cannot encode U+2713 (✓),
U+2717 (✗), and U+2014 (—). The same class of UnicodeEncodeError fixed
in miner.py via MemPalace#681 affects closet_llm.py and cli.py.

Replace with ASCII equivalents: [OK], [FAIL], [!], and hyphen.
@arnoldwender
arnoldwender force-pushed the fix/closet-llm-gbk-symbols branch from 91bf9b8 to 29db125 Compare May 30, 2026 12:47
@igorls
igorls merged commit 04af6a4 into MemPalace:develop Jun 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli CLI commands bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] UnicodeEncodeError when running mempalace mine on GBK console

2 participants