Skip to content

fix: Claude Code mining, hooks, split CLI, Chroma pin, status, Windows search - #120

Closed
actuallyrizzn wants to merge 1 commit into
MemPalace:mainfrom
actuallyrizzn:fix/hardening-five-issues
Closed

fix: Claude Code mining, hooks, split CLI, Chroma pin, status, Windows search#120
actuallyrizzn wants to merge 1 commit into
MemPalace:mainfrom
actuallyrizzn:fix/hardening-five-issues

Conversation

@actuallyrizzn

Copy link
Copy Markdown

This PR bundles six small, high-signal fixes (five tracked issues plus #40, which matches the same class of “silent wrong behavior”).

Issue What was wrong Fix
#111 Claude Code JSONL uses type: "user" but only human was recognized; tool-results/ and memory/ polluted mining Accept user; skip those dirs and *.meta.json
#110 Hook scripts interpolated paths into python -c strings Parse JSON once into safe assignments; open transcript via sys.argv[1]; sanitize session id for state filenames
#63 mempalace split <dir> passed a bare path; inner CLI expects --source Forward --source + expanded path
#100 Unpinned chromadb could pull 1.x with crashes chromadb>=0.6,<1 in pyproject.toml and requirements.txt
#40 status used get(limit=10000) only; palace_path with ~ not expanded from config Paginate get(); os.path.expanduser on config/env palace path
#47 Box-drawing chars break print on Windows cp1252 stdout.reconfigure(utf-8) on win32 before search output

Tests: ruff check, ruff format --check, pytest (13 tests) — run on Linux x86_64 with the pinned Chroma range.

- Claude Code JSONL: accept type user; skip tool-results/memory dirs and *.meta.json (#111)
- Hooks: safe JSON parse, transcript path via argv, sanitized session state files (#110)
- split: forward directory as --source to split_mega_files (#63)
- Pin chromadb to >=0.6,<1 (#100)
- Expand tilde in palace_path; paginate status past 10k drawers (#40)
- UTF-8 stdout on Windows before search prints (#47)

Tests: new coverage for JSONL user type, scan_convos skips, config expanduser.
Made-with: Cursor
@bensig

bensig commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for tackling these — most of these fixes have already been merged in #114 and #119. Closing to avoid conflicts.

@bensig bensig closed this Apr 7, 2026
@actuallyrizzn
actuallyrizzn deleted the fix/hardening-five-issues branch April 7, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants