fix: shell injection in hooks, Claude Code mining, chromadb pin - #114
Merged
Conversation
- hooks/mempal_save_hook.sh: pass $TRANSCRIPT_PATH as sys.argv instead of interpolating into python -c string (fixes #110) - normalize.py: accept type "user" in addition to "human" for Claude Code JSONL sessions (fixes #111) - convo_miner.py: skip tool-results/, memory/ dirs and .meta.json files when scanning for conversations (fixes #111) - pyproject.toml: pin chromadb>=0.4.0,<1 to avoid crashing 1.x builds on macOS ARM64 (fixes #100)
This was referenced Apr 7, 2026
Closed
Closed
GoodOlClint
added a commit
to GoodOlClint/mempalace
that referenced
this pull request
Apr 7, 2026
…DME) Merges upstream/main (b49cfbf) into our fork. Upstream merged: - MemPalace#114: shell injection fix, Claude Code mining, chromadb pin - MemPalace#119: repair command, split args fix, Claude export format, room keywords Conflicts resolved keeping our versions for overlapping fixes (MemPalace#110, MemPalace#111, MemPalace#100, MemPalace#108) plus our additions (remote support, batch writes, local embeddings, .gitignore, non-interactive init, subagents skip). New from upstream: - `mempalace repair` command to rebuild HNSW index after corruption - Claude privacy export format support in normalize.py - Updated README Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hooks/mempal_save_hook.sh:$TRANSCRIPT_PATHpassed assys.argv[1]via heredoc instead of interpolated into apython3 -cstringtype: "user"(not just"human"), skiptool-results/andmemory/dirs, skip.meta.jsonfileschromadb>=0.4.0,<1to avoid segfaulting 1.x Rust bindings on macOS ARM64Test plan
ruff check .passesruff format --check .passespytest tests/ -v— 9/9 pass