🚨 [security] Update carrierwave 1.3.1 → 1.3.4 (patch)

[depfu]

---

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

---

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ carrierwave (1.3.1 → 1.3.4) · Repo · Changelog

Security Advisories 🚨

🚨 Server-side request forgery in CarrierWave

Impact

[CarrierWave download feature](https://github.com/carrierwaveuploader/carrierwave#uploading-files-from-a-remote-location
has an SSRF vulnerability, allowing attacks to provide DNS entries or IP addresses that are intended for internal use
and gather information about the Intranet infrastructure of the platform.

Patches

Upgrade to 2.1.1 or
1.3.2.

Workarounds

Using proper network segmentation and applying the principle of least privilege to outbound connections from application
servers can reduce the severity of SSRF vulnerabilities. Ideally the vulnerable gem should run on an isolated server
without access to any internal network resources or cloud metadata access.

🚨 Code Injection vulnerability in CarrierWave::RMagick

Impact

CarrierWave::RMagick
has a Code Injection vulnerability. Its #manipulate! method inappropriately evals the content of mutation
option(:read/:write), allowing attackers to craft a string that can be executed as a Ruby code.
If an application developer supplies untrusted inputs to the option, it will lead to remote code execution(RCE).

(But supplying untrusted input to the option itself is dangerous even in absence of this vulnerability, since is prone to
DoS vulnerability - attackers can try to consume massive amounts of memory by resizing to a very large dimension)

Proof of Concept

class MyUploader < CarrierWave::Uploader::Base
  include CarrierWave::RMagick
end
MyUploader.new.manipulate!({ read: { density: "1 }; p 'Hacked'; {" }}) # => shows "Hacked"

Patches

Upgrade to 2.1.1 or
1.3.2.

Workarounds

Stop supplying untrusted input to #manipulate!'s mutation option.

Release Notes

1.3.4

Fixed

• Fix incompatibility with RMagick >= 3 (@marcogregorius #2699)

1.3.3

Fixed

• Fix Ruby 2.7 deprecation warning on Mounter#remove? (@kaoru #2644)
• Limit ssrf_filter to < 1.1.0 due to the breaking changes at 1.1.0 (@marcogregorius #2640)

1.3.2 (from changelog)

Fixed

• Fix Ruby 2.7 deprecations(@aubinlrx #2462)

Security

• Fix Code Injection vulnerability in CarrierWave::RMagick (@mshibuya eb9346df, GHSA-cf3w-g86h-35x4)
• Fix SSRF vulnerability in the remote file download feature (@mshibuya 91714add, GHSA-fwcm-636p-68r5)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 48 commits:

• Version 1.3.4
• Merge pull request #2699 from marcogregorius/test-ruby-3.2
• Test against Ruby 3.2 in CI
• Version 1.3.3
• Merge pull request #2644 from kaoru/1.x-stable
• Fix Ruby 2.7 deprecation warn on Mounter#remove?
• Add back the JRuby builds
• Fix ActiveRecord 4.x builds
• Merge pull request #2640 from marcogregorius/add-ci
• Set sqlite3 back to ~>1.3.6
• Bump sqlite3 version for rails <= 5.2
• fix gem dependencies
• Add Ruby >= 2.2 and Rails >= 4.0 back in matrix
• Remove ruby-head and jruby-head from test matrix
• Replace rails-master.gemfile with rails-main.gemfile
• Remove forked fog-google dependency
• Avoid breaking changes in ssrf_filter
• Fix obsolete URI.encode in spec
• Remove forked fog-google dependency
• Remove Postgresql and use sqlite3 for testing ActiveRecord
• Add CI on GitHub
• Version 1.3.2
• Fix Code Injection vulnerability in CarrierWave::RMagick
• Fix SSRF vulnerability in the remote file download feature
• URI.open does not exist before Ruby 2.5
• URI.encode becomes escape, not unescape
• Merge pull request #2462 from aubinlrx/tweak/deprecation_warning_ruby_27
• Cloud not make JRuby build pass on Xenial, reverting back to Trusty
• Fix build issues with PostgreSQL and ImageMagick
• use URI.open instead of Kernel.open for Ruby 2.7
• Use URI::DEFAULT_PARSER.unescape instead of URI.decode for Ruby 2.7
• Fix kwargs usage for Ruby 2.7
• Merge pull request #2377 from stanhu/sh-pass-openstack-options
• Merge pull request #2375 from QuickBlox/add-azure-rm-authenticated-url
• Merge pull request #2374 from hagarabdelwaha/master
• Travis's ImageMagick is pretty old, lock RMagick to 2.x
• Pass OpenStack options in get_object_https_url
• Add AzureRM to support authenticated_url
• Update README.md
• Merge pull request #2367 from nagatea/refactor_sanitized_file_path
• Fix JRuby builds
• Refactor SanitizedFile#path
• Use gemified version of activerecord-jdbcpostgresql-adapter
• CI against jruby 9.2
• CI against ruby 2.6
• CI against newer jruby 9.1.x
• We're still testing against old rubies that aren't supported by bundler 2.x
• CI against newer rubies

↗️ builder (indirect, 3.2.3 → 3.2.4) · Repo · Changelog

↗️ minitest (indirect, 5.11.3 → 5.20.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ tzinfo (indirect, 1.2.5 → 1.2.11) · Repo · Changelog

Security Advisories 🚨

🚨 TZInfo relative path traversal vulnerability allows loading of arbitrary files

Impact

Affected versions

• 0.3.60 and earlier.
• 1.0.0 to 1.2.9 when used with the Ruby data source (tzinfo-data).

Vulnerability

With the Ruby data source (the tzinfo-data gem for tzinfo version 1.0.0 and
later and built-in to earlier versions), time zones are defined in Ruby files.
There is one file per time zone. Time zone files are loaded with require on
demand. In the affected versions, TZInfo::Timezone.get fails to validate
time zone identifiers correctly, allowing a new line character within the
identifier. With Ruby version 1.9.3 and later, TZInfo::Timezone.get can be
made to load unintended files with require, executing them within the Ruby
process.

For example, with version 1.2.9, you can run the following to load a file with
path /tmp/payload.rb:

TZInfo::Timezone.get(\"foo\
/../../../../../../../../../../../../../../../../tmp/payload\")

The exact number of parent directory traversals needed will vary depending on
the location of the tzinfo-data gem.

TZInfo versions 1.2.6 to 1.2.9 can be made to load files from outside of the
Ruby load path. Versions up to and including 1.2.5 can only be made to load
files from directories within the load path.

This could be exploited in, for example, a Ruby on Rails application using
tzinfo version 1.2.9, that allows file uploads and has a time zone selector
that accepts arbitrary time zone identifiers.
The CVSS score and severity have been set on this basis.

Versions 2.0.0 and later are not vulnerable.

Patches

Versions 0.3.61 and 1.2.10 include fixes to correctly validate time zone
identifiers.

Note that version 0.3.61 can still load arbitrary files from the Ruby load
path if their name follows the rules for a valid time zone identifier and the
file has a prefix of tzinfo/definition within a directory in the load path.
For example if /tmp/upload was in the load path, then
TZInfo::Timezone.get('foo') could load a file with path
/tmp/upload/tzinfo/definition/foo.rb. Applications should ensure that
untrusted files are not placed in a directory on the load path.

Workarounds

As a workaround, the time zone identifier can be validated before passing to
TZInfo::Timezone.get by ensuring it matches the regular expression
\\A[A-Za-z0-9+\\-_]+(?:\\/[A-Za-z0-9+\\-_]+)*\\z.

Release Notes

1.2.11

• Eliminate Object#untaint deprecation warnings on JRuby 9.4.0.0. #145.

TZInfo v1.2.11 on RubyGems.org

1.2.10

• Fixed a relative path traversal bug that could cause arbitrary files to be loaded with require when used with RubyDataSource. Please refer to
  GHSA-5cm2-9h8c-rvfx for details. CVE-2022-31163.
• Ignore the SECURITY file from Arch Linux's tzdata package. #134.

TZInfo v1.2.10 on RubyGems.org

1.2.9

• Fixed an incorrect InvalidTimezoneIdentifier exception raised when loading a zoneinfo file that includes rules specifying an additional transition to the final defined offset (for example, Africa/Casablanca in version 2018e of the Time Zone Database). #123.

TZInfo v1.2.9 on RubyGems.org

1.2.8

• Added support for handling "slim" format zoneinfo files that are produced by default by zic version 2020b and later. The POSIX-style TZ string is now used calculate DST transition times after the final defined transition in the file. The 64-bit section is now always used regardless of whether Time has support for 64-bit times. #120.
• Rubinius is no longer supported.

TZInfo v1.2.8 on RubyGems.org

1.2.7

• Fixed 'wrong number of arguments' errors when running on JRuby 9.0. #114.
• Fixed warnings when running on Ruby 2.8. #112.

TZInfo v1.2.7 on RubyGems.org

1.2.6

• Timezone#strftime('%s', time) will now return the correct number of seconds since the epoch. #91.
• Removed the unused TZInfo::RubyDataSource::REQUIRE_PATH constant.
• Fixed "SecurityError: Insecure operation - require" exceptions when loading data with recent Ruby releases in safe mode.
• Fixed warnings when running on Ruby 2.7. #106 and #111.

TZInfo v1.2.6 on RubyGems.org

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🆕 ssrf_filter (added, 1.0.8)

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu cancel merge

Cancels automatic merging of this PR

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)