URI.encode becomes escape, not unescape

Refs. #2462
carrierwaveuploader · Oct 5, 2020 · ac3d006 · ac3d006
1 parent 0712435
commit ac3d006
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/carrierwave/uploader/download.rb b/lib/carrierwave/uploader/download.rb
@@ -92,8 +92,8 @@ def process_uri(uri)
       rescue URI::InvalidURIError
         uri_parts = uri.split('?')
         # regexp from Ruby's URI::Parser#regexp[:UNSAFE], with [] specifically removed
-        encoded_uri = URI::DEFAULT_PARSER.unescape(uri_parts.shift, /[^\-_.!~*'()a-zA-Z\d;\/?:@&=+$,]/)
-        encoded_uri << '?' << URI::DEFAULT_PARSER.unescape(uri_parts.join('?')) if uri_parts.any?
+        encoded_uri = URI::DEFAULT_PARSER.escape(uri_parts.shift, /[^\-_.!~*'()a-zA-Z\d;\/?:@&=+$,]/)
+        encoded_uri << '?' << URI::DEFAULT_PARSER.escape(uri_parts.join('?')) if uri_parts.any?
         URI.parse(encoded_uri) rescue raise CarrierWave::DownloadError, "couldn't parse URL"
       end