Skip to content

fix: Couple of tests are permanently broken while running locally #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 30, 2020
Merged

fix: Couple of tests are permanently broken while running locally #5

merged 18 commits into from
Sep 30, 2020

Conversation

@tina80lvl
Copy link

@tina80lvl tina80lvl commented Sep 21, 2020 •
edited
Loading

larkee and others added 13 commits May 26, 2020 14:09
@larkee
feat: release 2.2a0 (googleapis#457)
11222db 
Release-As: 2.2.a0

Co-authored-by: larkee <[email protected]>
@mf2199
feat: [WIP] The first stage of nox implementation (googleapis#468)
5551b58
feat: refactor connect() function, cover it with unit tests (googleap…
bfde221 
…is#462)
@mf2199
feat: Stage 2 of nox implementation - adding docs target (googlea…
e017901 
…pis#473)
@c24t
fix: Fix black, isort compatibility (googleapis#469)
144bdc2
@mf2199
feat: Stage 3-4 of nox implementation - adding auto-format targets (g…
7a1f6a6 
…oogleapis#478)
@mf2199
feat: Stage 5 of nox implementation - adding coverage targets (goog…
acd9209 
…leapis#479)
feat: cursor must detect if the parent connection is closed (googleap…
6028f88 
…is#463)
@mf2199
feat: Stage 6 of nox implementation - enabling system tests (google…
94ba284 
…apis#480)

Add googleapis/python-test-utils and system test stub
@mf2199
chore: Code refactoring to follow common Google API scheme - Stage I (g…
59eb432 
…oogleapis#487)
@c24t
chore: release 2.2a1 (googleapis#499)
048566c 
Release-As: 2.2.a1
Merge branch 'master' of https://github.com/googleapis/python-spanner…
f5719f8 
…-django
@tina80lvl
fix: Couple of tests are permanently broken while running locally
2c0c0a2
@tina80lvl
Copy link
Author

Previous value 1572851662.9782631 corresponded 04.11.2019 10:14:22, not 03.11.2019 23:14:22 as written in comments

@tina80lvl tina80lvl mentioned this pull request Sep 21, 2020
Closed
@tina80lvl tina80lvl self-assigned this Sep 21, 2020
mf2199
mf2199 reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The epoch timestamp [seconds] for Sunday, 3 November 2019 23:14:22 UTC is 1572822862, not 1572812062, as can be verified here. So either the value or the comment needs to be updated.

@mf2199
Copy link
Collaborator

mf2199 commented Sep 21, 2020

@tina80lvl Could you please also add a meaningful description to this PR. If it refers to an issue, then somewhere in that description should be a reference to it in a form of Fixes: #[issue-number]. The description can later be transfered to the corresponding public PR, so there is no danger of duplicating the effort.

@tina80lvl
Copy link
Author

The epoch timestamp [seconds] for Sunday, 3 November 2019 23:14:22 UTC is 1572822862, not 1572812062, as can be verified here. So either the value or the comment needs to be updated.

I'v found the problem. 1572812062 will be correct time in GMT+03:00, but absolute correct time is 1572822862. Test covers both values with GTM and without but I guess here can be mistake, I'll fix

IlyaFaer
IlyaFaer reviewed Sep 22, 2020
View reviewed changes
IlyaFaer
IlyaFaer approved these changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@IlyaFaer IlyaFaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, as it's seems to be working fine, I think we can create a public PR

@mf2199 mf2199 merged commit 9526cc2 into master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mf2199 mf2199 mf2199 left review comments

@IlyaFaer IlyaFaer IlyaFaer approved these changes

Assignees

@tina80lvl tina80lvl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Couple of tests are permanently broken while running locally

5 participants

@tina80lvl @mf2199 @IlyaFaer @larkee @c24t